Add collection parsing to the dev window for UI #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCommander
added
Issue: Feature
PJB3005
requested changes
Mar 16, 2024
Robust.Client/UserInterface/DevWindow/DevWindowTabUIPopup.xaml.cs
Outdated
Show resolved
Hide resolved
| <BoxContainer Name="ControlProperties" Orientation="Vertical" MouseFilter="Stop" /> | ||
| </ScrollContainer> | ||
| </SplitContainer> | ||
| </BoxContainer> | ||
| </PanelContainer> | ||
| <PopupContainer Name="PopupContainer" Access="Public" /> |
There was a problem hiding this comment.
I don't think I want to see this pattern of "making a custom PopupContainer become commonplace. I do understand it's because secondary OS windows don't have one themselves, but I'd rather see that resolved in CreateWindowRoot. You'd probably need to give WindowRoot a PopupContainer and then also some form of "ContentRoot" that further code is advised to use instead of directly adding to the WindowRoot.
There was a problem hiding this comment.
I'll see if I can add a PopupContainer to WindowRoot in another PR.
ShadowCommander
added
Status: Needs Review
PJB3005
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conversions from string and control collections to strings.
Added popup when clicking a value to show value.
Before:
After:
Before:
After: