Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityCoordinates and MapCoordinates args are inverse #2853

Open
metalgearsloth opened this issue May 23, 2022 · 0 comments · May be fixed by #5389
Open

EntityCoordinates and MapCoordinates args are inverse #2853

metalgearsloth opened this issue May 23, 2022 · 0 comments · May be fixed by #5389
Labels
Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. Issue: Needs Cleanup This issue needs general code cleanup. Priority: 2-Important Size: Very Large For especially large issues/PRs. I pity you.

Comments

@metalgearsloth
Copy link
Contributor

Ideally I'd prefer (Vector2, EntityUid) but really I just want them consistent between each other.
@metalgearsloth metalgearsloth added Issue: Needs Cleanup This issue needs general code cleanup. Priority: 2-Important Size: Very Large For especially large issues/PRs. I pity you. Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. labels May 23, 2022
@Winkarst-cpu Winkarst-cpu linked a pull request Aug 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: 1-Easy Not impossible to figure out for newer coders, and simple for experienced ones. Issue: Needs Cleanup This issue needs general code cleanup. Priority: 2-Important Size: Very Large For especially large issues/PRs. I pity you.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EntityCoordinates and MapCoordinates consistency Winkarst-cpu/RobustToolbox
1 participant
@metalgearsloth