Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sync #2718

Merged
merged 144 commits into from
Oct 30, 2024
Merged

Upstream sync #2718

merged 144 commits into from
Oct 30, 2024

Conversation

Morb0
Copy link
Member

@Morb0 Morb0 commented Oct 30, 2024

Описание PR

Почему / Баланс

Технические детали

Медиа

Требования

Критические изменения

Список изменений

slarticodefast and others added 30 commits October 15, 2024 20:57
* Adds emotes to the Reptilian species: Tailthump, Hiss
Todo: Huff

* Adds emotes to the Reptilian species: Tailthump, Hiss
Todo: Huff

* Added ReptilianBodyEmotes to speech_emote_sounds.yml, yada yada yada

* added sound and changed volume

* fix thingies

* fixed bug with reptilians not being able to do default emotes

* lowered the volume of the hiss and huff

* reformat the yml

* Add sigh keywords to the huff

* Undo changes to BuildChecker.csproj

* Add icons to the emotes

* Remove sigh triggers from the huff emote since it breaks normal sighing.

* Remove the Huff and Hiss since i cant find good audio for it

* i forgor

* Changed attribution

* Credit Sarahon for the tailslap

---------

Co-authored-by: nicho <[email protected]>
* le fixo smotes

* CURSE OF BLINDNESS

* Guh
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Add robo control comp, also de-reinforce a lot of walls.

* Revert "Add robo control comp, also de-reinforce a lot of walls."

This reverts commit b6be6b616aa9732b81e02bed76e3c9ae103cf7cb.

* FTLdiskburner command to make FTL disks.

* Elegant failure on mistyped ID.

* even more more eleganter failures.

* foo

* bar

* I have reached completion

* prevent id confusion

* I'm givin' her all she's got captain!

* a bit more hug boxing for safe destinations.

* comments for foo

* extra thoughts.

* cleanup

* continuen't

* Improve feedback strings

* reviewer QOL

* Reviewer QOL 2

* handle easy reviews

* Add comments to clarify reviews

* howdoicode to the rescue.

* ftldisk in hand

* ftl.ftl

* funny disk case

* loc

* unusing
* Several small sfx tweaks

* fix small yml oopsie

* Redo the basin code to use events

* now uses an event for when the transfer is successful, not when there's just an attempt

* forgot to remove this

* Update Content.Server/Botany/Components/PlantHolderComponent.cs

Co-authored-by: Nemanja <[email protected]>

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

Co-authored-by: Nemanja <[email protected]>

* adds sound variations to shoes as well

* variations on honkbots and the H.O.N.K mech

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

* fix compile issue

* oops forgot to delete this

* cleanup

---------

Co-authored-by: Nemanja <[email protected]>
Co-authored-by: metalgearsloth <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
* changed bananium desc

* removed bananium name and desc ftl string
* enable ejecting in biogenerator UI

* allow inserting too

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
* Subversion Board Insertion Audio Notification

Add Subversion flag and SubversionSound to SiliconLawProviderComponent

Add new Method (OnSubversionInserted)
to SiliconLawSystem to handle a Subversive
SiliconLawProviderComponent and play it's SubversionSound

Add Check for Subversive law provider to OnUpdaterInsert that
calls OnSubversionInserted if the SiliconLawProviderComponent is
Subversive

* Fix subversion Sound

- Change out Weh sound used to test that subversion sounds can be
changed by prototype for a a not yet present Antimov subversion sound

* Make it not just subversive

- Remove OnSubversionInserted and move the MindPlaySound in the
OnUpdaterInsert so long as LawUploadSound exists

- Modify SubversionSound into LawUploadSound

- Remove the Subversion flag

- Just use emagged_borg.ogg until the better one is made

* Remove errant spaces and a errant namespace

* CR Fixes - Add generic Lawboard insert cue

- Combine the If statements per /pull/32625#discussion_r1786926400
inside OnUpdaterInsert

- Remove the ViewVariables(VVAccess.ReadWrite) per
pull/32625#discussion_r1786924433

- Add Cryo_warning.ogg from TGStation, the sound utilized for Law Upload
cue, Attribution.

* CR Add a placeholder Antimov notification sound

- Add a new sound kitbashed from the cryo_sound used for uploading
and the emagged noise

* Add self referential source attribution

- also fix an errant space

* Add more bespoke Sound by ps3moira + attributions
this was just copypasted without any context wasn't it
…erience (#32851)

set FancyWindow MinHeight to 210
* Change the window titlebar to show the joined server

Requires space-wizards/RobustToolbox#5475

* Totally not a webedit

* Can you tell what cvar I copied?

* And this kids is why we don't webedit

* Reviews

---------

Co-authored-by: metalgearsloth <[email protected]>
* Rename ChatSanitizationManager to ChatEmoteSanitizationManager

The prior name was kind of confusing as there's a emote one and
then now there's also chat expansion happening in the accent system,
so knowing which I actually need to edit is useful.

So, I just need to keep myself not confused.

* Rename smileyToEmote and remove punctuation duplicates

The name SmileyToEmote is just... Bad.

Plus, I needed to remove the punctuation duplicates as that would
break any kind of regex parsing that I tried.

* Switch to regex from checking end of string

I also changed from System.Globalization to ILocalizationManager.

Writing that regex was definitely an experience.

* Document regex and the manager

* Rename it back

* Simplify regex
small ai core lv change
deltanedas and others added 19 commits October 29, 2024 00:00
Co-authored-by: deltanedas <@deltanedas:kde.org>
I don't really understand why RecordedSplitContainer exists but removing it looks identical and fixes the panel bumping occasionally.
…ap, Brig Timer (#32786)

* various resprites (encryption keys + signal screens + station map)

* brig timer update

* fixes n shit
…ate the crusher and glaive icons. (#32212)

* inhands

* better inhands

* indent
* replace tear gas and flashbang with holobarrier and sec radio

* holobarrier-belt-fix
three bottle boxes in nanomed plus
…(#32720)

* a-few-injectors

* comment

* defib-ops-when
# Conflicts:
#	Content.Server/Chat/Managers/ChatSanitizationManager.cs
#	Content.Shared/Localizations/ContentLocalizationManager.cs
#	Resources/Audio/Weapons/Guns/Gunshots/attributions.yml
#	Resources/Prototypes/Datasets/Names/last.yml
#	Resources/Prototypes/Loadouts/loadout_groups.yml
#	Resources/ServerInfo/Guidebook/Antagonist/Traitors.xml
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Oct 30, 2024
Copy link
Contributor

RSI Diff Bot; head commit 6e6fd0f merging into 4fad639
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/ai_card.rsi

State Old New Status
base Modified
empty Modified
full Modified

Resources/Textures/Objects/Devices/encryption_keys.rsi

State Old New Status
crypt_blue Modified
crypt_gold Modified
crypt_gray Modified
crypt_orange Modified
crypt_red Modified
crypt_rusted Modified
crypt_silver Modified

Resources/Textures/Objects/Devices/tablets.rsi

State Old New Status
generic Modified
tablet Modified
tabletsol Modified

Resources/Textures/Objects/Specific/Chemistry/syringe.rsi

State Old New Status
syringeproj Modified
minisyringe1 Added
minisyringe2 Added
minisyringe3 Added

Resources/Textures/Objects/Tools/appraisal-tool.rsi

State Old New Status
equipped-BELT Modified
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/anti_materiel.rsi

State Old New Status
mag-1 Modified
mag-2 Added

Resources/Textures/Clothing/Multiple/towel.rsi

State Old New Status
NTmono Added
equipped-BELT Added
equipped-HELMET Added
equipped-INNERCLOTHING Added
icon Added
iconstripe Added
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Fun/spectrallocator.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
screen Added

Resources/Textures/Objects/Specific/Medical/defibsmall.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
ready Added
screen Added

Resources/Textures/Objects/Specific/Medical/defibsyndi.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
ready Added
screen Added

Resources/Textures/Objects/Specific/Medical/medipen.rsi

State Old New Status
dexpen Added
dexpen_empty Added
punctpen Added
punctpen_empty Added
pyrapen Added
pyrapen_empty Added

@Morb0 Morb0 merged commit 1e51fdc into master Oct 30, 2024
14 of 15 checks passed
@Morb0 Morb0 deleted the upstream-sync branch October 30, 2024 15:24
lzk228 added a commit to lzk228/space-station-14 that referenced this pull request Oct 30, 2024
lzk228 added a commit that referenced this pull request Oct 30, 2024
Co-authored-by: NotSoDamn <[email protected]>
Co-authored-by: mhamster <[email protected]>
Co-authored-by: lapatison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.