Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for missing ruleId. #9

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Allow for missing ruleId. #9

merged 1 commit into from
Dec 18, 2023

Conversation

Ronoman
Copy link
Contributor

@Ronoman Ronoman commented Nov 19, 2022

This will be introduced if this ament_lint PR is merged. More commits will be added on this PR to support better de-duplication, depending on discussion in that PR's comments.

@mjeronimo mjeronimo added the bug Something isn't working label May 16, 2023
@ivanperez-keera
Copy link

I just posted a comment in the associated PR in ament_lint to try to move things along.

@Bckempa Bckempa added this to the humble-2024.01.0 milestone Dec 3, 2023
@Bckempa
Copy link
Contributor

Bckempa commented Dec 3, 2023

Provisionally nominating for inclusion in the next release, we're waiting on upstream for the the fix to ament_lint but that doesn't seem to preclude getting this one-liner merged.

@Bckempa Bckempa self-requested a review December 18, 2023 02:40
Copy link
Contributor

@Bckempa Bckempa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by building the current release ros2.repos workspace from source, using colcon test to generate test artifacts, then using ros2 run process-sarif visualize to parse the test logs. Then this PR's branch was loaded into the workspace and rebuilt without rerunning the tests. Finally the new version of process_sarif was used to parse the same artifacts with equivalent results.

Since this adds a defensive measure against future change but has no impact on current behavior I will approve and merge this PR.

Current release:

Result Kinds: {'UNKNOWN': 1609, 'PASS': 0, 'OPEN': 0, 'INFORMATIONAL': 0, 'REVIEW': 15822, 'FAIL': 0}
Result Levels: {'UNKNOWN': 1377, 'ERROR': 232, 'WARNING': 15822, 'NOTE': 0, 'NONE': 0}

This PR:

Result Kinds: {'UNKNOWN': 1609, 'PASS': 0, 'OPEN': 0, 'INFORMATIONAL': 0, 'REVIEW': 15822, 'FAIL': 0}
Result Levels: {'UNKNOWN': 1377, 'ERROR': 232, 'WARNING': 15822, 'NOTE': 0, 'NONE': 0}

@Bckempa Bckempa mentioned this pull request Dec 18, 2023
@Bckempa Bckempa linked an issue Dec 18, 2023 that may be closed by this pull request
@Bckempa Bckempa merged commit 81a2004 into main Dec 18, 2023
@Bckempa Bckempa deleted the results-fixes branch December 18, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow for missing ruleId
4 participants