Custom LFS Sever #970
Merged
Custom LFS Sever #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the compression code that was added to lower the amount of LFS bandwidth that is used. We have spun up a custom LFS server, so we can safely bring back the raw JSON files as we're not as concerned about bandwidth.
Oh JSON, my structured delight, In curly braces, you shine so bright. Keys and values, a dance so neat, A coder's joy, both terse and sweet. Your syntax sings in nested rhyme, Parsing truths in real-time. Arrays and objects, a seamless stream, You hold the data of every dream. Through RESTful calls, you traverse the air, A universal format, beyond compare. Oh JSON, my digital muse, In you, a world of logic I choose.
|
We good. 👍 |
The `actions/checkout@v4` action does not support `.lfsconfig` files, which means that our custom LFS server can't be used with this action. The work around is to disable the LFS operation in the action then manually pull the LFS files in a step after the normal repo is pulled down.
|
From what we tested the other day, this seems like it should work, hopefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've created our own Git Large File Storage (LFS) server due to the excessive cost of GitHub's bandwidth. Did you know all of their Ethernet cables are actually gold coated diamonds?
This PR reverses the work done in #954 to compress large location JSON files into a 7zip archive and handle the (de)compression of the archive.
Only JSON files within the
project/assets/database/directory that are larger than 5MB have been included in LFS. This translates to all of thelooseLoot.jsonfiles. The rest are small enough to be included in the base repo.A
.lfsconfigfile has been added to the root of the project to alert git to the presence of the custom LFS server. This public server is read-only. Write access is only available to developers within the Single Player Tarkov GitHub organization.