Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SaveServer and the things that interact with it to be async #1064

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Refactor SaveServer and the things that interact with it to be async #1064

merged 3 commits into from
Jan 10, 2025

Conversation

ArchangelWTF
Copy link
Contributor

Changes:

  • Adds a map for profiles
  • Changes onBeforeSaveCallbacks to be Promises
  • Changes SaveMD5 into saveSHA1 as the async method for saveSHA1 isn't blocking
  • Changes all routes and callbacks directly interacting with SaveServer to be async

@chompDev chompDev merged commit 1d1104a into sp-tarkov:4.0.0-DEV Jan 10, 2025
1 of 3 checks passed
@ArchangelWTF ArchangelWTF deleted the saveserver-refactor branch January 30, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chompDev chompDev chompDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArchangelWTF @chompDev