Development Strict Mode #1006
Merged
Development Strict Mode #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates version numbers in `.nvmrc`, `package.json`, and `Server.code-workspace` - Updates `@yao-pkg/pkg`, `@yao-pkg/pkg-fetch`, and `@types/node` to latest - Updates JSON import to FS read operation in `gulpfile.mjs` - Updates node build target in `gulpfile.mjs`
- Enables TS strict mode - Adds script to check types - Adds workflow to run check-type script - Updates the code-checking workflows to share the same set-up job This updates the `tsconfig.json` option to enable strict mode. *However*, we use TSX for development and SWC for release, which do not type-check, so this option only gives additional linting/visual-feedback in VSCode. Additionally, I've added a NPM script `npm run lint:types` and a GitHub workflow that runs it.
Updates the upload-artifact action to v4. Specifies some additional options.
Updates the download-artifact action to v4.
Updates the NPM scripts to use NPX to call vitest scripts to help issues in CI.
Reverts to original workflow design and implements NPM package caching.
|
I'm done messing with the workflows. Definitely squash this one. 😄 |
chompDev
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
tsconfig.jsonoption to enable strict mode. However, we use TSX for development and SWC for release, which do not type-check, so this option only gives additional linting/visual-feedback in VSCode.Additionally, I've added a NPM script
npm run lint:typesand a GitHub workflow that runs it.This depends on #1005.