Fixed offer quantity only updating when trader offer had buy restrict…

…ions
sp-tarkov · Feb 21, 2025 · b37900d · b37900d
1 parent be80033
commit b37900d
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/project/src/helpers/TradeHelper.ts b/project/src/helpers/TradeHelper.ts
@@ -78,29 +78,33 @@ export class TradeHelper {
 
                 // We store ragfair offerid in buyRequestData.item_id
                 const offerWithItem = allOffers.find((x) => x._id === buyRequestData.item_id);
-                const itemPurchased = offerWithItem.items[0];
+                const rootItemPurchased = offerWithItem.items[0];
+
+                // Update offer quantity
+                offerWithItem.quantity -= buyCount;
 
                 // Ensure purchase does not exceed trader item limit
-                const assortHasBuyRestrictions = this.itemHelper.hasBuyRestrictions(itemPurchased);
+                const assortHasBuyRestrictions = this.itemHelper.hasBuyRestrictions(rootItemPurchased);
                 if (assortHasBuyRestrictions) {
                     this.checkPurchaseIsWithinTraderItemLimit(
                         sessionID,
                         pmcData,
                         buyRequestData.tid,
-                        itemPurchased,
+                        rootItemPurchased,
                         buyRequestData.item_id,
                         buyCount,
                     );
 
-                    // Decrement trader item count
+                    // Decrement trader current purchase count in profile
                     const itemPurchaseDetails = {
                         items: [{ itemId: buyRequestData.item_id, count: buyCount }],
                         traderId: buyRequestData.tid,
                     };
-                    this.traderHelper.addTraderPurchasesToPlayerProfile(sessionID, itemPurchaseDetails, itemPurchased);
-
-                    // Update offer quantity
-                    offerWithItem.quantity -= buyCount;
+                    this.traderHelper.addTraderPurchasesToPlayerProfile(
+                        sessionID,
+                        itemPurchaseDetails,
+                        rootItemPurchased,
+                    );
                 }
             };