Modify files to make linter happy

sp-tarkov · Jan 9, 2025 · 7c20e16 · 7c20e16
1 parent 5d7d20f
commit 7c20e16
Show file tree

Hide file tree

Showing 25 changed files with 137 additions and 72 deletions.
diff --git a/project/src/controllers/DialogueController.ts b/project/src/controllers/DialogueController.ts
@@ -83,10 +83,12 @@ export class DialogueController {
 
         // Add any friends the user has after the chatbots
         const profile = this.profileHelper.getFullProfile(sessionID);
-        for (const friendId of profile?.friends) {
-            const friendProfile = this.profileHelper.getChatRoomMemberFromSessionId(friendId);
-            if (friendProfile) {
-                friends.push(friendProfile);
+        if (profile?.friends) {
+            for (const friendId of profile.friends) {
+                const friendProfile = this.profileHelper.getChatRoomMemberFromSessionId(friendId);
+                if (friendProfile) {
+                    friends.push(friendProfile);
+                }
             }
         }
 

diff --git a/project/src/controllers/GameController.ts b/project/src/controllers/GameController.ts
@@ -256,6 +256,7 @@ export class GameController {
         // Hideout Improvement property changed name
         if ((fullProfile.characters.pmc.Hideout as any).Improvement) {
             fullProfile.characters.pmc.Hideout.Improvements = (fullProfile.characters.pmc.Hideout as any).Improvement;
+            // biome-ignore lint/performance/noDelete: Delete is fine here, as we're seeking to remove these entirely
             delete (fullProfile.characters.pmc.Hideout as any).Improvement;
             this.logger.warning(`Migration: Moved Hideout Improvement data to new property 'Improvements'`);
         }
@@ -273,12 +274,14 @@ export class GameController {
         // Remove PMC 'ragfair' from trader list
         if (fullProfile.characters.pmc.TradersInfo.ragfair) {
             this.logger.warning("Migration: deleting: ragfair traderinfo object from PMC");
+            // biome-ignore lint/performance/noDelete: Delete is fine here, as we're seeking to remove these entirely
             delete fullProfile.characters.pmc.TradersInfo.ragfair;
         }
 
         // Remove SCAV 'ragfair' from trader list
         if (fullProfile.characters.scav.TradersInfo.ragfair) {
             this.logger.warning("Migration: deleting: ragfair traderinfo object from PMC");
+            // biome-ignore lint/performance/noDelete: Delete is fine here, as we're seeking to remove these entirely
             delete fullProfile.characters.scav.TradersInfo.ragfair;
         }
 
@@ -561,6 +564,7 @@ export class GameController {
     protected checkForAndRemoveUndefinedDialogs(fullProfile: ISptProfile): void {
         const undefinedDialog = fullProfile.dialogues.undefined;
         if (undefinedDialog) {
+            // biome-ignore lint/performance/noDelete: Delete is fine here, as we're seeking to delete undefined dialogs.
             delete fullProfile.dialogues.undefined;
         }
     }

diff --git a/project/src/controllers/HealthController.ts b/project/src/controllers/HealthController.ts
@@ -250,6 +250,7 @@ export class HealthController {
 
                 // Remove empty effect object
                 if (Object.keys(pmcData.Health.BodyParts[bodyPartKey].Effects).length === 0) {
+                    // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the effect.
                     delete pmcData.Health.BodyParts[bodyPartKey].Effects;
                 }
             }

diff --git a/project/src/controllers/HideoutController.ts b/project/src/controllers/HideoutController.ts
@@ -1229,6 +1229,7 @@ export class HideoutController {
 
         if (hasMildPain) {
             // Already has mild pain, remove mild and add severe
+            // biome-ignore lint/performance/noDelete: Deleting is fine here, we're removing the effect to replace it with another.
             delete pmcData.Health.BodyParts.Chest.Effects.MildMusclePain;
 
             pmcData.Health.BodyParts.Chest.Effects.SevereMusclePain = {

diff --git a/project/src/controllers/InventoryController.ts b/project/src/controllers/InventoryController.ts
@@ -282,7 +282,7 @@ export class InventoryController {
 
         // Remove FiR status from destination stack when source stack has no FiR but destination does
         if (!sourceItem.upd.SpawnedInSession && destinationItem.upd.SpawnedInSession) {
-            delete destinationItem.upd.SpawnedInSession;
+            destinationItem.upd.SpawnedInSession = false;
         }
 
         destinationItem.upd.StackObjectsCount += sourceItem.upd.StackObjectsCount; // Add source stackcount to destination
@@ -408,6 +408,7 @@ export class InventoryController {
         if (request.to.location) {
             itemOne.location = request.to.location;
         } else {
+            // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the location.
             delete itemOne.location;
         }
 
@@ -416,6 +417,7 @@ export class InventoryController {
         if (request.to2.location) {
             itemTwo.location = request.to2.location;
         } else {
+            // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the location.
             delete itemTwo.location;
         }
 
@@ -721,6 +723,7 @@ export class InventoryController {
             if (change.location) {
                 inventoryItem.location = change.location;
             } else {
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the location.
                 delete inventoryItem.location;
             }
         }

diff --git a/project/src/generators/BotWeaponGenerator.ts b/project/src/generators/BotWeaponGenerator.ts
@@ -571,9 +571,12 @@ export class BotWeaponGenerator {
         }
 
         // Inner join the weapons allowed + passed in cartridge pool to get compatible cartridges
-        const compatibleCartridges = Object.keys(cartridgePoolForWeapon)
-            .filter((cartridge) => compatibleCartridgesInTemplate.includes(cartridge))
-            .reduce((acc, key) => ({ ...acc, [key]: cartridgePoolForWeapon[key] }), {});
+        const compatibleCartridges = {};
+        for (const cartridge of Object.keys(cartridgePoolForWeapon)) {
+            if (compatibleCartridgesInTemplate.includes(cartridge)) {
+                compatibleCartridges[cartridge] = cartridgePoolForWeapon[cartridge];
+            }
+        }
 
         if (!compatibleCartridges) {
             // No compatible cartridges, use default

diff --git a/project/src/generators/LootGenerator.ts b/project/src/generators/LootGenerator.ts
@@ -397,9 +397,9 @@ export class LootGenerator {
         const presetAndMods: IItem[] = this.itemHelper.replaceIDs(chosenPreset._items);
         this.itemHelper.remapRootItemId(presetAndMods);
         // Add chosen preset tpl to result array
-        presetAndMods.forEach((item) => {
+        for (const item of presetAndMods) {
             result.push(item);
-        });
+        }
 
         if (itemLimitCount) {
             // Increment item count as item has been chosen and its inside itemLimitCount dictionary

diff --git a/project/src/generators/RagfairOfferGenerator.ts b/project/src/generators/RagfairOfferGenerator.ts
@@ -403,7 +403,9 @@ export class RagfairOfferGenerator {
             this.itemHelper.reparentItemAndChildren(clonedAssort[0], clonedAssort);
 
             // Clear unnecessary properties
+            // biome-ignore lint/performance/noDelete: Deleting is fine here, we're getting rid of unecessary properties.
             delete clonedAssort[0].parentId;
+            // biome-ignore lint/performance/noDelete: Deleting is fine here, we're getting rid of unecessary properties.
             delete clonedAssort[0].slotId;
 
             assortSingleOfferProcesses.push(

diff --git a/project/src/generators/RepeatableQuestRewardGenerator.ts b/project/src/generators/RepeatableQuestRewardGenerator.ts
@@ -309,20 +309,22 @@ export class RepeatableQuestRewardGenerator {
             itemsToReturn.push({ item: chosenItemFromPool, stackSize: rewardItemStackCount });
 
             const itemCost = this.presetHelper.getDefaultPresetOrItemPrice(chosenItemFromPool._id);
-            itemRewardBudget -= rewardItemStackCount * itemCost;
+            const calculatedItemRewardBudget = itemRewardBudget - rewardItemStackCount * itemCost;
             this.logger.debug(`Added item: ${chosenItemFromPool._id} with price: ${rewardItemStackCount * itemCost}`);
 
             // If we still have budget narrow down possible items
-            if (itemRewardBudget > 0) {
+            if (calculatedItemRewardBudget > 0) {
                 // Filter possible reward items to only items with a price below the remaining budget
                 exhausableItemPool = new ExhaustableArray(
-                    this.filterRewardPoolWithinBudget(itemPool, itemRewardBudget, 0),
+                    this.filterRewardPoolWithinBudget(itemPool, calculatedItemRewardBudget, 0),
                     this.randomUtil,
                     this.cloner,
                 );
 
                 if (!exhausableItemPool.hasValues()) {
-                    this.logger.debug(`Reward pool empty with: ${itemRewardBudget} roubles of budget remaining`);
+                    this.logger.debug(
+                        `Reward pool empty with: ${calculatedItemRewardBudget} roubles of budget remaining`,
+                    );
                     break; // No reward items left, exit
                 }
             }

diff --git a/project/src/generators/ScavCaseRewardGenerator.ts b/project/src/generators/ScavCaseRewardGenerator.ts
@@ -321,6 +321,7 @@ export class ScavCaseRewardGenerator {
 
             // Clean up upd object if it wasn't used
             if (!rootItem.upd) {
+                // biome-ignore lint/performance/noDelete: Delete is fine here, we're cleaning up this object without leaving an undefined.
                 delete rootItem.upd;
             }
 

diff --git a/project/src/helpers/HealthHelper.ts b/project/src/helpers/HealthHelper.ts
@@ -293,6 +293,7 @@ export class HealthHelper {
         for (const bodyPart in bodyPartsWithEffects) {
             // clear effects from profile bodyPart
             if (deleteExistingEffects) {
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the effect.
                 delete pmcData.Health.BodyParts[bodyPart].Effects;
             }
 
@@ -339,6 +340,7 @@ export class HealthHelper {
 
         // Delete empty property to prevent client bugs
         if (this.isEmpty(profileBodyPart.Effects)) {
+            // biome-ignore lint/performance/noDelete: Delete is fine here, we're removing an empty property to prevent game bugs.
             delete profileBodyPart.Effects;
         }
     }

diff --git a/project/src/helpers/HideoutHelper.ts b/project/src/helpers/HideoutHelper.ts
@@ -180,8 +180,11 @@ export class HideoutHelper {
                 break;
             case BonusType.TEXT_BONUS:
                 // Delete values before they're added to profile
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the data.
                 delete bonus.passive;
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the data.
                 delete bonus.production;
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the data.
                 delete bonus.visible;
                 break;
         }
@@ -781,6 +784,7 @@ export class HideoutHelper {
             }
 
             // Filter ran out / used up
+            // biome-ignore lint/performance/noDelete: Delete is fine here, as we're seeking to entirely delete the water filter.
             delete waterFilterArea.slots[i].item;
             // Update remaining resources to be subtracted
             filterDrainRate = Math.abs(resourceValue);
@@ -919,6 +923,7 @@ export class HideoutHelper {
                     break; // Break here to avoid updating all filters
                 }
 
+                // biome-ignore lint/performance/noDelete: Delete is fine here, as we're seeking to entirely delete the air filter.
                 delete airFilterArea.slots[i].item;
                 // Update remaining resources to be subtracted
                 filterDrainRate = Math.abs(resourceValue);

diff --git a/project/src/helpers/InRaidHelper.ts b/project/src/helpers/InRaidHelper.ts
@@ -118,7 +118,9 @@ export class InRaidHelper {
         });
 
         for (const item of itemsToRemovePropertyFrom) {
-            delete item.upd.SpawnedInSession;
+            if (item.upd) {
+                item.upd.SpawnedInSession = false;
+            }
         }
     }
 

diff --git a/project/src/helpers/InventoryHelper.ts b/project/src/helpers/InventoryHelper.ts
@@ -177,10 +177,14 @@ export class InventoryHelper {
             // Ensure item has upd object
             this.itemHelper.addUpdObjectToItem(item);
 
+            if (!item.upd) {
+                item.upd = {};
+            }
+
             if (foundInRaid) {
                 item.upd.SpawnedInSession = foundInRaid;
             } else {
-                delete item.upd.SpawnedInSession;
+                item.upd.SpawnedInSession = false;
             }
         }
     }
@@ -191,14 +195,17 @@ export class InventoryHelper {
      */
     protected removeTraderRagfairRelatedUpdProperties(upd: IUpd): void {
         if (upd.UnlimitedCount !== undefined) {
+            // biome-ignore lint/performance/noDelete: Delete is fine here since we're attempting to remove this fully here.
             delete upd.UnlimitedCount;
         }
 
         if (upd.BuyRestrictionCurrent !== undefined) {
+            // biome-ignore lint/performance/noDelete: Delete is fine here since we're attempting to remove this fully here.
             delete upd.BuyRestrictionCurrent;
         }
 
         if (upd.BuyRestrictionMax !== undefined) {
+            // biome-ignore lint/performance/noDelete: Delete is fine here since we're attempting to remove this fully here.
             delete upd.BuyRestrictionMax;
         }
     }
@@ -997,6 +1004,7 @@ export class InventoryHelper {
                 } else {
                     // No location in request, delete it
                     if (itemToMove.location) {
+                        // biome-ignore lint/performance/noDelete: Delete is fine here as we're trying to remove the entire data property.
                         delete itemToMove.location;
                     }
                 }
@@ -1059,6 +1067,7 @@ export class InventoryHelper {
         } else {
             // Moved from slot with location to one without, clean up
             if (matchingInventoryItem.location) {
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we're trying to remove the entire data property.
                 delete matchingInventoryItem.location;
             }
         }

diff --git a/project/src/helpers/ItemHelper.ts b/project/src/helpers/ItemHelper.ts
@@ -1194,6 +1194,7 @@ export class ItemHelper {
 
             // In live no ammo box has the first cartridge item with a location
             if (location === 0) {
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the location.
                 delete cartridgeItemToAdd.location;
             }
 
@@ -1366,6 +1367,7 @@ export class ItemHelper {
 
         // Only one cartridge stack added, remove location property as its only used for 2 or more stacks
         if (location === 1) {
+            // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the location.
             delete magazineWithChildCartridges[1].location;
         }
     }
@@ -1706,6 +1708,7 @@ export class ItemHelper {
             if (!parentExists && item.parentId !== rootId && item.slotId !== "hideout") {
                 item.parentId = rootId;
                 item.slotId = "hideout";
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we entirely want to get rid of the location.
                 delete item.location;
             }
         }
@@ -1800,7 +1803,10 @@ export class ItemHelper {
      */
     public removeSpawnedInSessionPropertyFromItems(items: IItem[]): void {
         for (const item of items) {
-            delete item.upd.SpawnedInSession;
+            if (item.upd) {
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we're removing the entire property.
+                delete item.upd.SpawnedInSession;
+            }
         }
     }
 }

diff --git a/project/src/helpers/QuestHelper.ts b/project/src/helpers/QuestHelper.ts
@@ -253,6 +253,7 @@ export class QuestHelper {
             existingQuest.completedConditions = [];
 
             if (existingQuest.availableAfter) {
+                // biome-ignore lint/performance/noDelete: Delete is fine here as we're trying to remove the entire data property.
                 delete existingQuest.availableAfter;
             }
 

diff --git a/project/src/models/eft/common/IEmptyRequestData.ts b/project/src/models/eft/common/IEmptyRequestData.ts
@@ -1 +1,2 @@
+// biome-ignore lint/complexity/noBannedTypes: Empty request is empty, this is fine.
 export type IEmptyRequestData = {};
diff --git a/project/src/services/BotEquipmentModPoolService.ts b/project/src/services/BotEquipmentModPoolService.ts
@@ -82,7 +82,7 @@ export class BotEquipmentModPoolService {
 
                         // Check item added into array for slots, need to iterate over those
                         const subItemDetails = this.itemHelper.getItem(itemToAdd)[1];
-                        const hasSubItemsToAdd = subItemDetails?._props?.Slots?.length ?? 0 > 0;
+                        const hasSubItemsToAdd = (subItemDetails?._props?.Slots?.length ?? 0) > 0;
                         if (hasSubItemsToAdd && !pool[subItemDetails._id]) {
                             // Recursive call
                             this.generatePool([subItemDetails], poolType);

diff --git a/project/src/services/FenceService.ts b/project/src/services/FenceService.ts
@@ -165,6 +165,7 @@ export class FenceService {
         }
 
         // Clean up the items
+        // biome-ignore lint/performance/noDelete: Delete is fine here as we're getting rid of the items before updating.
         delete root.location;
 
         const createAssort: ICreateFenceAssortsResult = { sptItems: [], barter_scheme: {}, loyal_level_items: {} };
@@ -1115,14 +1116,16 @@ export class FenceService {
                 continue;
             }
 
+            let armorWithMods = armorItemAndMods;
+
             const modItemDbDetails = this.itemHelper.getItem(plateTpl)[1];
 
             // Chance to remove plate
             const plateExistsChance =
                 this.traderConfig.fence.chancePlateExistsInArmorPercent[modItemDbDetails._props?.armorClass ?? "3"];
             if (!this.randomUtil.getChance100(plateExistsChance)) {
                 // Remove plate from armor
-                armorItemAndMods = armorItemAndMods.filter(
+                armorWithMods = armorItemAndMods.filter(
                     (item) => item.slotId.toLowerCase() !== plateSlot._name.toLowerCase(),
                 );
 
@@ -1135,13 +1138,13 @@ export class FenceService {
             );
 
             // Find items mod to apply dura changes to
-            const modItemToAdjust = armorItemAndMods.find(
+            const modItemToAdjust = armorWithMods.find(
                 (mod) => mod.slotId.toLowerCase() === plateSlot._name.toLowerCase(),
             );
 
             if (!modItemToAdjust) {
                 this.logger.warning(
-                    `Unable to randomise armor items ${armorItemAndMods[0]._tpl} ${plateSlot._name} slot as it cannot be found, skipping`,
+                    `Unable to randomise armor items ${armorWithMods[0]._tpl} ${plateSlot._name} slot as it cannot be found, skipping`,
                 );
                 continue;
             }

diff --git a/project/src/services/ItemFilterService.ts b/project/src/services/ItemFilterService.ts
@@ -29,7 +29,9 @@ export class ItemFilterService {
      */
     public isItemBlacklisted(tpl: string): boolean {
         if (this.itemBlacklistCache.size === 0) {
-            this.itemConfig.blacklist.forEach((item) => this.itemBlacklistCache.add(item));
+            for (const item of this.itemConfig.blacklist) {
+                this.itemBlacklistCache.add(item);
+            }
         }
 
         return this.itemBlacklistCache.has(tpl);
@@ -42,7 +44,9 @@ export class ItemFilterService {
      */
     public isLootableItemBlacklisted(tpl: string): boolean {
         if (this.lootableItemBlacklistCache.size === 0) {
-            this.itemConfig.lootableItemBlacklist.forEach((item) => this.itemBlacklistCache.add(item));
+            for (const item of this.itemConfig.lootableItemBlacklist) {
+                this.itemBlacklistCache.add(item);
+            }
         }
 
         return this.lootableItemBlacklistCache.has(tpl);
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		// biome-ignore lint/complexity/noBannedTypes: Empty request is empty, this is fine.
		export type IEmptyRequestData = {};