Updated static loot generation to better handle malformed modded items

sp-tarkov · Jan 11, 2025 · 6081a19 · 6081a19
1 parent 0b287a8
commit 6081a19
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/project/src/generators/LocationLootGenerator.ts b/project/src/generators/LocationLootGenerator.ts
@@ -429,6 +429,9 @@ export class LocationLootGenerator {
         const tplsToAddToContainer = tplsForced.concat(chosenTpls);
         for (const tplToAdd of tplsToAddToContainer) {
             const chosenItemWithChildren = this.createStaticLootItem(tplToAdd, staticAmmoDist, parentId);
+            if (!chosenItemWithChildren) {
+                continue;
+            }
 
             const items = this.locationConfig.tplsToStripChildItemsFrom.includes(tplToAdd)
                 ? [chosenItemWithChildren.items[0]] // Strip children from parent
@@ -956,6 +959,11 @@ export class LocationLootGenerator {
         parentId?: string,
     ): IContainerItem {
         const itemTemplate = this.itemHelper.getItem(chosenTpl)[1];
+        if (!itemTemplate._props) {
+            this.logger.error(`Unable to process item: ${chosenTpl}. it lacks _props`);
+
+            return undefined;
+        }
         let width = itemTemplate._props.Width;
         let height = itemTemplate._props.Height;
         let items: IItem[] = [{ _id: this.hashUtil.generate(), _tpl: chosenTpl }];