Fix for IE 11-compatible Babel transpilation #242
Conversation
| { | ||
| "preset-env": { | ||
| "useBuiltIns": "entry", | ||
| "corejs": 3, |
There was a problem hiding this comment.
Newer than the default. Default would be 2, also this line is necessary to get rid of a warning.
| }, | ||
| "transform-runtime": { | ||
| "corejs": 3, | ||
| "useESModules": false |
There was a problem hiding this comment.
Without this, the server code would crash on start.
| "babel-plugin-styled-components" | ||
| ], | ||
| "env": { | ||
| "ttag": { |
There was a problem hiding this comment.
This is the configuration used when running Babel with BABEL_ENV=ttag.
There was a problem hiding this comment.
did you test the pot file extraction with these changes?
There was a problem hiding this comment.
I didn't look in detail at the .pot file, but it was generated correctly.
| "pull-translations": "tx pull -af", | ||
| "retranslate": "npm run build && npm run pull-translations && NEW_SOURCE_PO='./src/static/i18n/en_US.txt' retranslate/run.sh", |
| "> 1%" | ||
| "> 0.25%", | ||
| "not dead" |
There was a problem hiding this comment.
Support a few more browsers because why not :)
| @@ -313,72 +313,70 @@ export default class App extends BaseApp { | |||
| }; | |||
|
|
|||
| return ( | |||
| <Container> | |||
There was a problem hiding this comment.
Next.js 9 doesn't need this component wrapper anymore. Everything below this line in this file is just Prettier's re-indentation, feel free to ignore :)
| "babel-plugin-styled-components" | ||
| ], | ||
| "env": { | ||
| "ttag": { |
There was a problem hiding this comment.
did you test the pot file extraction with these changes?
This cleans up browserslist /
babel/preset-envconfiguration and fixes IE11 by movingbabel-plugin-ttagout of the way when Next.js / Webpack / Babel transpiles our code.Here is a more detailed description of the issue: ttag-org/babel-plugin-ttag#138
For fun, it includes little changes to remove deprecation warnings in Next 9.