-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve #21 get_remote_info via ssh itself #24
base: master
Are you sure you want to change the base?
Conversation
a5802c5
to
4bd013e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, need to test that and will report back, thanks!
Great! Sorry, but can't link this pr to issue #21 |
I like this approach as well, because it works, for example, with |
@soyuka is everything good? |
Probably busy giving talks :) I have been using the fork so far and all is good |
And we are still waaaaiting |
Improve
get_remote_info
function by making it to fetch actual ssh configuration options (like host, port, user) viassh -G
and parse its output, instead of parsing ~/.ssh/config file.This makes the plugin unbound from the
.ssh/config
file and more accurate in case of multipleHost some-wildcard*
sections, e.g.:So, on
ssh prod-app
correct values will be:according to
ssh -G prod-app | head -4
And on
ssh myself@prod-app -p 9999
correct values will be:according to
ssh -G myself@prod-app -p 9999 | head -4