Skip to content

Commit

Permalink
fix: performance optimization (#358)
Browse files Browse the repository at this point in the history
* refactor: add alt to social login image

* fix: add omission attribute to button tag

* fix: add meta tag

* fix: add robots text file for seo
  • Loading branch information
soyoung125 authored Nov 21, 2024
1 parent 17d2c88 commit 2b43256
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<!-- <meta http-equiv="Content-Security-Policy" content="upgrade-insecure-requests">-->

<meta content="width=device-width, initial-scale=1.0" name="viewport"/>
<meta name="description" content="일정과 자산 관리를 한 번에 도와주는 애플리케이션 핀더펜" />
<meta name=”robots” content=”nofollow” />
<meta name="apple-mobile-web-app-title" content="FinThePen"/>
<meta name="apple-mobile-web-app-capable" content="yes"/>
<meta name="apple-mobile-web-app-status-bar-style" content="#735bf2"/>
Expand Down
4 changes: 4 additions & 0 deletions public/robots.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
User-agent: *
Disallow: /src/app/*
Disallow: /src/assets/*
Disallow: /src/mocks/*
3 changes: 2 additions & 1 deletion src/pages/Start/components/SocialLogin/SocialLogin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ function SocialLogin({ type }: SocialLoginProps) {
sx={{
p: 0,
}}
aria-label={`social_${type}`}
>
<img src={SOCIAL_LOGIN[type].image} width={40} />
<img src={SOCIAL_LOGIN[type].image} width={40} alt={`social_${type}`} />
</Button>
</Box>
);
Expand Down

0 comments on commit 2b43256

Please sign in to comment.