Socket mode client is run as an IHostedService in ASP.NET

Deprecated SlackEndpointConfiguration.SocketModeConnectionOptions setter
soxtoby · Sep 25, 2024 · f0a2da7 · f0a2da7
1 parent 76f3a5a
commit f0a2da7
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 11 deletions.
diff --git a/SlackNet.AspNetCore/AspNetCoreExtensions.cs b/SlackNet.AspNetCore/AspNetCoreExtensions.cs
@@ -24,17 +24,11 @@ public static IServiceCollection AddSlackNet(this IServiceCollection serviceColl
     /// </summary>
     public static IApplicationBuilder UseSlackNet(this IApplicationBuilder app, Action<SlackEndpointConfiguration> configure = null)
     {
-        var config = new SlackEndpointConfiguration();
+        var config = app.ApplicationServices.GetRequiredService<SlackEndpointConfiguration>();
         configure?.Invoke(config);
 
-        if (config.SocketMode)
-        {
-            app.ApplicationServices.GetRequiredService<ISlackSocketModeClient>().Connect();
-            return app;
-        }
-        else
-        {
-            return app.UseMiddleware<SlackRequestMiddleware>(config);
-        }
+        return config.SocketMode 
+            ? app // Nothing to do - SocketModeService manages the client
+            : app.UseMiddleware<SlackRequestMiddleware>(config);
     }
 }
diff --git a/SlackNet.AspNetCore/AspNetSlackServiceConfiguration.cs b/SlackNet.AspNetCore/AspNetSlackServiceConfiguration.cs
@@ -34,6 +34,7 @@ protected internal AspNetSlackServiceConfiguration(IServiceCollection serviceCol
         ServiceCollection.TryAddSingleton<IHttpContextAccessor, HttpContextAccessor>();
         ServiceCollection.TryAddSingleton<IRequestServiceProviderAccessor, HttpContextServiceProviderAccessor>();
         ServiceCollection.TryAddSingleton<IServiceProviderSlackRequestListener, AspNetCoreServiceProviderSlackRequestListener>();
+        ServiceCollection.AddHostedService<SocketModeService>();
 
         base.ConfigureServices();
     }

diff --git a/SlackNet.AspNetCore/SlackEndpointConfiguration.cs b/SlackNet.AspNetCore/SlackEndpointConfiguration.cs
@@ -88,5 +88,5 @@ public SlackEndpointConfiguration DelayResponse(bool delay = true)
     public bool VerifyEventUrl { get; private set; } = true;
     public bool SocketMode { get; private set; }
     public bool DelayedResponse { get; private set; }
-    public SocketModeConnectionOptions SocketModeConnectionOptions { get; set; }
+    public SocketModeConnectionOptions SocketModeConnectionOptions { get; [Obsolete("Pass options to UseSocketMode instead.")] set; }
 }
diff --git a/SlackNet.AspNetCore/SlackNet.AspNetCore.csproj b/SlackNet.AspNetCore/SlackNet.AspNetCore.csproj
@@ -29,6 +29,7 @@
     <PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.1.1" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="1.1.8" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="2.2.0" />
+    <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="2.1.1" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" />
     <PackageReference Include="System.Text.Encodings.Web" Version="4.5.1" />
   </ItemGroup>

diff --git a/SlackNet.AspNetCore/SocketModeService.cs b/SlackNet.AspNetCore/SocketModeService.cs
@@ -0,0 +1,38 @@
+using System;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
+
+namespace SlackNet.AspNetCore;
+
+class SocketModeService(
+    ISlackSocketModeClient socketModeClient,
+    ILogger<SocketModeService> logger,
+    SlackEndpointConfiguration config
+) : IHostedService
+{
+    private readonly bool _enabled = config.SocketMode; // Holding onto this to ensure initial state is used when stopping
+
+    public async Task StartAsync(CancellationToken cancellationToken)
+    {
+        if (_enabled)
+        {
+            try
+            {
+                await socketModeClient.Connect(config.SocketModeConnectionOptions, cancellationToken).ConfigureAwait(false);
+            }
+            catch (Exception e)
+            {
+                logger.LogError(e, "Error connecting Slack socket mode client");
+            }
+        }
+    }
+
+    public Task StopAsync(CancellationToken cancellationToken)
+    {
+        if (_enabled)
+            socketModeClient.Disconnect();
+        return Task.CompletedTask;
+    }
+}