Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password update function on user edit page #397

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Password update function on user edit page #397

merged 6 commits into from
Dec 13, 2024

Conversation

kamilczaja
Copy link
Collaborator

@kamilczaja kamilczaja commented Dec 12, 2024 •
edited
Loading

Checklist
Preview Give feedback

@kamilczaja kamilczaja linked an issue Dec 12, 2024 that may be closed by this pull request
Implement password change functionality #393
Closed
@kamilczaja kamilczaja force-pushed the 393-implement-password-change-functionality branch from 6a0ca10 to 231e869 Compare December 13, 2024 09:43
@kamilczaja kamilczaja requested a review from PaddseL December 13, 2024 13:41
@PaddseL
Copy link
Member

PaddseL commented Dec 13, 2024

Is it correct that you don't have to confirm your current password when changing the password?

PaddseL
PaddseL requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@PaddseL PaddseL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good to me, suggested some minor changes and added a general question.

CHANGELOG.md Outdated Show resolved Hide resolved
...rc/app/pages/control-center-user-edit-page/state/control-center-user-edit-page-state-impl.ts Outdated Show resolved Hide resolved
authority-portal-frontend/src/app/core/services/config/app-config.ts Show resolved Hide resolved
@kamilczaja
Copy link
Collaborator Author

kamilczaja commented Dec 13, 2024 •
edited
Loading

Is it correct that you don't have to confirm your current password when changing the password?

Keycloak decides for itself if it wants to re-authenticate. It did prompt me for the old password + OTP on some occasions so I assume it determines that depending on the auth token age or something

PaddseL
PaddseL approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@PaddseL PaddseL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilczaja kamilczaja enabled auto-merge (squash) December 13, 2024 17:25
@kamilczaja kamilczaja merged commit e7dcc73 into main Dec 13, 2024
12 checks passed
@kamilczaja kamilczaja deleted the 393-implement-password-change-functionality branch December 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaddseL PaddseL PaddseL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement password change functionality
2 participants
@kamilczaja @PaddseL