fix: favicon, page titles (#61)

sovity · Mar 13, 2024 · 70445a0 · 70445a0
1 parent d8fadcb
commit 70445a0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,7 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md).
 - Fix provisioning CaaS breaking dashboard ([#27](https://github.com/sovity/authority-portal/issues/27))
 - Fixed the text being cut off in the connector self-hosting instructions ([#35](https://github.com/sovity/authority-portal/issues/35))
 - Fixed inconsistent placeholder values for privacy policy and legal notice links ([#41](https://github.com/sovity/authority-portal/issues/41))
+- Fixed favicon and page titles being not aligned with breadcrumb ([[#48](https://github.com/sovity/authority-portal/issues/48)])
 - Fixed misleading UptimeKuma endpoint documentation ([#26](https://github.com/sovity/authority-portal/issues/26))
 - Fixed components being displayed as online when UptimeKuma is unreachable
 - Cleaned up repository for open-source release:

diff --git a/...y-portal-frontend/src/app/common/layouts/portal-layout/breadcrumb/breadcrumb.component.ts b/...y-portal-frontend/src/app/common/layouts/portal-layout/breadcrumb/breadcrumb.component.ts
@@ -11,6 +11,7 @@
  *      sovity GmbH - initial implementation
  */
 import {Component, OnDestroy} from '@angular/core';
+import {Title} from '@angular/platform-browser';
 import {Subject, takeUntil} from 'rxjs';
 import {BreadcrumbItem} from './breadcrumb.model';
 import {BreadcrumbService} from './breadcrumb.service';
@@ -22,11 +23,17 @@ import {BreadcrumbService} from './breadcrumb.service';
 export class BreadcrumbComponent implements OnDestroy {
   breadcrumb: BreadcrumbItem[] = [];
 
-  constructor(private breadcrumbService: BreadcrumbService) {
+  constructor(
+    private breadcrumbService: BreadcrumbService,
+    private titleService: Title,
+  ) {
     this.breadcrumbService.breadcrumb$
       .pipe(takeUntil(this.ngOnDestroy$))
       .subscribe((breadcrumb) => {
         this.breadcrumb = breadcrumb;
+        this.titleService.setTitle(
+          'MDS ' + breadcrumb[breadcrumb.length - 1].label || 'Portal',
+        );
       });
   }
 

diff --git a/authority-portal-frontend/src/favicon.ico b/authority-portal-frontend/src/favicon.ico
diff --git a/authority-portal-frontend/src/index.html b/authority-portal-frontend/src/index.html
@@ -5,7 +5,7 @@
     <title>Authority Portal</title>
     <base href="/" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
-    <link rel="icon" type="image/x-icon" href="favicon.ico" />
+    <link rel="icon" type="image/x-icon" href="assets/images/logo_light.svg" />
   </head>
 
   <body>