-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating of document via cli #3474
fix: Updating of document via cli #3474
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3474 +/- ##
===========================================
+ Coverage 78.31% 78.40% +0.09%
===========================================
Files 397 397
Lines 37571 37574 +3
===========================================
+ Hits 29423 29459 +36
+ Misses 6439 6416 -23
+ Partials 1709 1699 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
8e5665f
to
54c679e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Islam!
SupportedClientTypes: immutable.Some( | ||
[]testUtils.ClientType{testUtils.HTTPClientType, testUtils.CLIClientType}), | ||
Actions: []any{ | ||
testUtils.UpdateWithFilter{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: I forgot we had this, thanks for using it and not doing whatever I suggested in the standup 😁 Thanks for the comment too, it explains it nicely.
Relevant issue(s)
Resolves #3470
Description
Make
client collection update
always expect--updater
parameter.Change filter expectation from
{ "_gte": { "points": 100 } }
to'{ "points": { "_gte": 100 } }
Make db expect filter param as
map[string]any
.