Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(i): Fix debug explain test-framework with similarity #3473

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #3471

Description

  • Add compile time check to ensure similarity node is explainable.
  • Fix debug explain test-framework with similarity query
  • Add a debug explain test

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI

@shahzadlone shahzadlone added bug Something isn't working area/testing Related to any test or testing suite labels Feb 20, 2025
@shahzadlone shahzadlone added this to the DefraDB v0.16 milestone Feb 20, 2025
@shahzadlone shahzadlone self-assigned this Feb 20, 2025
@shahzadlone shahzadlone changed the title test(I): Fix debug explain test-framework with similarity test(i): Fix debug explain test-framework with similarity Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (05f9fb1) to head (2f62a5a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3473      +/-   ##
===========================================
+ Coverage    78.37%   78.39%   +0.02%     
===========================================
  Files          397      397              
  Lines        37571    37571              
===========================================
+ Hits         29445    29451       +6     
+ Misses        6423     6418       -5     
+ Partials      1703     1702       -1     
Flag Coverage Δ
all-tests 78.39% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/planner/explain.go 59.40% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f9fb1...2f62a5a. Read the comment docs.

@shahzadlone shahzadlone requested a review from a team February 20, 2025 16:31
@shahzadlone shahzadlone changed the title test(i): Fix debug explain test-framework with similarity test(): Fix debug explain test-framework with similarity Feb 20, 2025
@shahzadlone shahzadlone changed the title test(): Fix debug explain test-framework with similarity test(i): Fix debug explain test-framework with similarity Feb 20, 2025
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the lone/test/fix-debug-explain-test-framework-bug branch from e3c31e5 to 2f62a5a Compare February 20, 2025 22:03
@shahzadlone shahzadlone merged commit 816e550 into sourcenetwork:develop Feb 20, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosine similarity debug testing framework explain bug
2 participants