Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make --no-encryption flag work without keyring #3466

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #3465

Description

Make --no-encryption flag work without keyring

@islamaliev islamaliev added the bug Something isn't working label Feb 19, 2025
@islamaliev islamaliev requested a review from a team February 19, 2025 16:29
@islamaliev islamaliev self-assigned this Feb 19, 2025
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming you have manually tested this - if not, please do :)

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (6f286cf) to head (66f248c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
cli/start.go 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3466   +/-   ##
========================================
  Coverage    78.50%   78.50%           
========================================
  Files          396      396           
  Lines        37333    37334    +1     
========================================
+ Hits         29306    29307    +1     
- Misses        6342     6343    +1     
+ Partials      1685     1684    -1     
Flag Coverage Δ
all-tests 78.50% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cli/start.go 26.17% <0.00%> (-0.10%) ⬇️

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f286cf...66f248c. Read the comment docs.

@islamaliev
Copy link
Contributor Author

LGTM - assuming you have manually tested this - if not, please do :)

yes, I tested it

@islamaliev islamaliev merged commit 7107187 into sourcenetwork:develop Feb 19, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag --no-encryption is ignored if keyring is enabled
2 participants