Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Go version to 1.24.0 #146

Merged
merged 1 commit into from
Feb 21, 2025
+12 −6
Merged

chore: Bump Go version to 1.24.0 #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
golang 1.23.3
golang 1.24.0
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# ChangeLog

## Unreleased

- Upgrades Dockerfile to use Go 1.24.0 (released Feb 11 2025).
(https://github.com/sourcegraph/scip-go/pull/146)

## v0.1.22

- Fixes a panic when using a custom GOPACKAGESDRIVER along
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@
# <other stuff to ignore>
# And use this digest in FROM

ARG base_sha=73f06be4578c9987ce560087e2e2ea6485fb605e3910542cadd8fa09fc5f3e31
ARG base_sha=2b1cbf278ce05a2a310a3d695ebb176420117a8cfcfcc4e5e68a1bef5f6354da

FROM golang:1.23.3@sha256:${base_sha} as builder
FROM golang:1.24.0@sha256:${base_sha} AS builder

COPY . /sources
WORKDIR /sources
RUN go build -o scip-go ./cmd/scip-go

# Keep in sync with builder image
FROM golang:1.23.3@sha256:${base_sha} as final
FROM golang:1.24.0@sha256:${base_sha} AS final

COPY --from=builder /sources/scip-go /usr/bin/
CMD ["scip-go"]
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/sourcegraph/scip-go

go 1.23.3
go 1.24.0

require (
github.com/charmbracelet/log v0.4.0
Expand Down
3 changes: 2 additions & 1 deletion internal/loader/stdlib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// THIS FILE IS GENERATED. SEE ./scripts/gen_std_lib.sh
// Generated by: go version go1.23.3 darwin/arm64
// Generated by: go version go1.24.0 darwin/arm64
package loader

var contained = struct{}{}
Expand Down Expand Up @@ -55,4 +55,5 @@ var stdPackages = map[string]struct{}{
"unique": contained,
"unsafe": contained,
"vendor": contained,
"weak": contained,
}