Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Varun Gandhi <[email protected]>
  • Loading branch information
podtserkovskiy and varungandhi-src authored Oct 30, 2024
1 parent c6bfa51 commit 7efd7ee
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmd/scip-go/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func init() {

app.Flag("profile", "Turn on debug profiling. This will reduce performance. Do not turn on unless debugging. Set to number of milliseconds per sample").Default("0").IntVar(&profileRate)

app.Arg("package-patterns", "Package patterns to index. Default: ./... - indexes all packages in current directory recursively.").Default("./...").StringsVar(&packagePatterns)
app.Arg("package-patterns", "Package patterns to index. Default: './...' which indexes all packages in the current directory recursively. For the full syntax of allowed package patterns, see https://pkg.go.dev/cmd/go#hdr-Package_lists_and_patterns").Default("./...").StringsVar(&packagePatterns)
}

func main() {
Expand Down
4 changes: 2 additions & 2 deletions internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type IndexOpts struct {
IsIndexingStdlib bool

// Package patterns to index
PackagePatters []string
PackagePatterns []string
}

func New(ModuleRoot, ModuleVersion, ModulePath, GoStdlibVersion string, IsIndexingStdlib bool, SkipImplementations bool, SkipTests bool, PackagePatters []string) IndexOpts {
Expand All @@ -36,6 +36,6 @@ func New(ModuleRoot, ModuleVersion, ModulePath, GoStdlibVersion string, IsIndexi
SkipImplementations: SkipImplementations,
SkipTests: SkipTests,
IsIndexingStdlib: IsIndexingStdlib,
PackagePatters: PackagePatters,
PackagePatterns: PackagePatterns,
}
}
2 changes: 1 addition & 1 deletion internal/loader/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func LoadPackages(
}()

cfg := getConfig(moduleRoot, opts)
pkgs, err := packages.Load(cfg, opts.PackagePatters...)
pkgs, err := packages.Load(cfg, opts.PackagePatterns...)
if err != nil {
return err
}
Expand Down

0 comments on commit 7efd7ee

Please sign in to comment.