Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention @ in the placeholder message #553

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Mention @ in the placeholder message #553

merged 2 commits into from
Feb 12, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Feb 8, 2024 •
edited
Loading

Test plan

  1. runIde
  2. see Cody tool window
image image

@mkondratek mkondratek self-assigned this Feb 8, 2024
@taylorsperry
Copy link
Contributor

taylorsperry commented Feb 8, 2024 •
edited
Loading

Thanks, @mkondratek ! I'll defer to @danielmarquespt on design, but I think this is already an improvement. Is it possible to suggest the open file as soon as I type @ (like VS Code does)? I feel like you type @ and expect something to happen / don't know what to do next.
Screenshot 2024-02-08 at 4 47 34 PM

@taylorsperry taylorsperry mentioned this pull request Feb 9, 2024
Closed
@mkondratek
Copy link
Contributor Author

Taylor, it's fixed by #555 🚀

@mkondratek mkondratek enabled auto-merge (squash) February 9, 2024 01:05
@mkondratek mkondratek force-pushed the mkondratek/fix/cody-message branch from c746e78 to d9047f4 Compare February 9, 2024 11:34
@mkondratek
Copy link
Contributor Author

I applied the fixes:

. .
image image

@mkondratek mkondratek force-pushed the mkondratek/fix/cody-message branch 2 times, most recently from 84c226c to a51ba5e Compare February 12, 2024 17:50
@mkondratek mkondratek force-pushed the mkondratek/fix/cody-message branch from a51ba5e to 65ba720 Compare February 12, 2024 19:12
Sa1to
Sa1to approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Sa1to Sa1to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 5c031c0 into main Feb 12, 2024
0 of 2 checks passed
@mkondratek mkondratek deleted the mkondratek/fix/cody-message branch February 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkukielka pkukielka pkukielka left review comments

@danielmarquespt danielmarquespt danielmarquespt left review comments

@Sa1to Sa1to Sa1to approved these changes

Assignees

@mkondratek mkondratek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkondratek @taylorsperry @pkukielka @danielmarquespt @Sa1to