Migrate testing/test #2639
Closed
Migrate testing/test #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-5
branch
from
5152a75 to
39b6d47
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-4
branch
from
e3be1ea to
f2bdee3
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-5
branch
from
39b6d47 to
7a529a0
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-5
branch
3 times, most recently
from
011c23c to
6137074
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-5
branch
from
6137074 to
9800a57
Compare
mkondratek
commented
Nov 26, 2024
| @@ -109,6 +112,8 @@ open class CodyIntegrationTextFixture : BasePlatformTestCase(), LensListener { | |||
| } | |||
|
|
|||
| private fun checkInitialConditions() { | |||
| isAuthenticated() | |||
There was a problem hiding this comment.
It does not matter.
With the check the tests fail with User is not authenticated assertion error.
Without it it fails with:
junit.framework.ComparisonFailure: Action description should be empty expected:<[]> but was:<[Log in to Sourcegraph to enable Cody features]>
at junit.framework.Assert.assertEquals(Assert.java:100)
at junit.framework.TestCase.assertEquals(TestCase.java:253)
at com.sourcegraph.cody.util.CodyIntegrationTextFixture.checkInitialConditions(CodyIntegrationTextFixture.kt:140)
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-5
branch
from
9800a57 to
42947df
Compare
|
closing in favour of sourcegraph/cody#6293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of the protocol migration. Some endpoints are written by hand. We are switching to the protocol generated from Cody. In this PR:
Based on PR #2638
Full chain of PRs as of 2024-11-13
mkondratek/chore/migrate-api-part-5➔mkondratek/chore/migrate-api-part-4mkondratek/chore/migrate-api-part-4➔mkondratek/chore/migrate-api-part-3xmkondratek/chore/migrate-api-part-3x➔mainTest plan