show context files on empty at-expression (#555)

sourcegraph · Feb 9, 2024 · e4d470b · e4d470b
1 parent a1da1ee
commit e4d470b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/main/java/com/sourcegraph/cody/PromptPanel.kt b/src/main/java/com/sourcegraph/cody/PromptPanel.kt
@@ -269,13 +269,18 @@ data class AtExpression(
     val value: String
 )
 
-val atExpressionPattern = """(@(?:\\\s|[^\s])+)(?:\s|$)""".toRegex()
+val atExpressionPattern = """(@(?:\\\s|\S)*)(?:\s|$)""".toRegex()
 
 fun findAtExpressions(text: String): List<AtExpression> {
   val matches = atExpressionPattern.findAll(text)
   val expressions = ArrayList<AtExpression>()
   for (match in matches) {
-    val subMatch = match.groups.get(1)
+    val mainMatch = match.groups[0] ?: continue
+    val prevIndex = mainMatch.range.first - 1
+    // filter out things like email addresses
+    if (prevIndex >= 0 && !text[prevIndex].isWhitespace()) continue
+
+    val subMatch = match.groups[1]
     if (subMatch != null) {
       val value = subMatch.value.substring(1).replace("\\ ", " ")
       expressions.add(

diff --git a/src/test/kotlin/com/sourcegraph/cody/PromptPanelTest.kt b/src/test/kotlin/com/sourcegraph/cody/PromptPanelTest.kt
@@ -33,7 +33,12 @@ class PromptPanelTest : TestCase() {
                         "foo ".length + "@file\\ with\\ spaces".length,
                         "@file\\ with\\ spaces",
                         "file with spaces"),
-                )))
+                )),
+            Case("@", listOf(AtExpression(0, 1, "@", ""))),
+            Case("foo @", listOf(AtExpression("foo ".length, "foo @".length, "@", ""))),
+            Case("@ foo", listOf(AtExpression(0, 1, "@", ""))),
+            Case("[email protected]", listOf()),
+        )
 
     for (case in cases) {
       assertEquals(case.expected, findAtExpressions(case.text))