feat: add runAsUser and runAsGroup to executor #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpleiness
reviewed
Feb 5, 2025
Chickensoupwithrice
force-pushed
the
al/REL-690/add-run-as-user-executor
branch
from
ac67495 to
893551c
Compare
jdpleiness
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
@marcleblanc2 please run this through in your test cluster to make sure it meets the requirements.
Approving for now though as it looks good from here.
3 tasks
Chickensoupwithrice
added a commit
that referenced
this pull request
Feb 19, 2025
The start of a resolution for [REL-690](https://linear.app/sourcegraph/issue/REL-690/add-runasuser-runasgroup-fsgroup-to-executor-helm-chart). Need to test this out to see how it works. There are sample overrides in [this thread](https://sourcegraph.slack.com/archives/C0418GDBT7S/p1738581012896529?thread_ts=1738580801.517539&cid=C0418GDBT7S) ### Checklist - [x] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) ### Test plan Run the example overrides from the thread and see if the executor runs and doesn't fail. In particular we want a _named_ user that is not privileged. <br> Backport 45e5817 from #632 Co-authored-by: Anish Lakhwara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start of a resolution for REL-690.
Need to test this out to see how it works. There are sample overrides in this thread
Checklist
Test plan
Run the example overrides from the thread and see if the executor runs and doesn't fail. In particular we want a named user that is not privileged.