fix(chat): expansion of current-tab generic mention when non editor tabs are opened

[ichim-david]

Here are a few short videos:

1. The bug in action:

broken-current-tabs-behavior.mp4

2. Besides fixing the generic replacement I also added an option to selectedCodePromptWithExtraFiles
   in order to get rid of parenthesis wrapping the otherMentions if we don't need it such as in the case of the current-tabs.

current-tabs-with-parenthesis.mp4

and the fix:

current-tabs-without-parenthesis.mp4

Test plan

1. Create a prompt that uses the current-tab mention.
2. Open the Settings panel on VSCode (command + ,)
3. Run the prompt and notice it being replaced by the opened editor tabs instead of remaining on cody://current-tabs

[beyang]

Do we ever need the "wrapped in parentheses" behavior? IMO, it's not clear that improves response quality (at best, it probably just makes whatever is sent to the LLM look janky; at worst, the non-standard formatting of having parens wrap multiple code snippets might throw the LLM "off distribution)". If there is no reason to have the parens, we could just remove them entirely and save the extra parameter here.

[vovakulikov]

Nice, thanks for fixing this, I agree that wrapping is actually not needed anymore (I think it was used at some point when we had one "primary" file and "other" files, but I can't think of any current usage of this where this is still important.

[ichim-david]

@beyang @vovakulikov
You guys are using the wrapping within the execute of default commands such as explain code, document code,
find code smell etc.
See all calls for "selectedCodePromptWithExtraFiles":
https://github.com/search?q=repo%3Asourcegraph%2Fcody%20selectedCodePromptWithExtraFiles&type=code

There you are taking "the selected code" and replacing it with file:linenumber-linenumber(file)
https://github.com/sourcegraph/cody/blob/main/vscode/src/commands/execute/explain.ts#L48

This only happens when you use the execute command and not when you call the prompt directly.
Have a look at this video where I show what I mean:

explain-code-command-vs-prompt.mp4

Given the fact that this doesn't happen when you call the prompt from the prompt choose, I would be in favor
of getting rid of this replacing behavior and we could also remove the addition of ().

The reason why I kept this functionality working was because I was aware that it is used in the command execution
and I didn't want to fix a bug only to insert a bug :).

If we are also on the topic of having parenthesis added I would set my flag to remove them also from this
prompt:
https://github.com/sourcegraph/cody/blob/main/vscode/src/prompts/prompt-hydration.ts#L309

I chose not todo it in order to keep this pull request pure, fix only issues for current-tab replacement and get
feedback on my actions.

What happens from here is up to what you guys want me todo now that I have presented these situations.

[vovakulikov]

@ichim-david Sorry for the delay here (we had quite a week with our latest release), I see what you mean with commands wrapping, TL;DR commands are soft deprecated at the moment and will be replaced fully with prompts (we already reached a good enough feature parity with them in prompts library) so I wouldn't worry about commands much here. We can remove wrapping there too.

[ichim-david]

@ichim-david Sorry for the delay here (we had quite a week with our latest release), I see what you mean with commands wrapping, TL;DR commands are soft deprecated at the moment and will be replaced fully with prompts (we already reached a good enough feature parity with them in prompts library) so I wouldn't worry about commands much here. We can remove wrapping there too.

@beyang and @vovakulikov I've removed the addition of parenthesis as you guys suggested. Once this pull request will be merged the explain command will behave like this

I suggest that any cleanup made to the commands to make them act like the prompt should be made in another pull request to avoid handling another task in the same pull request.
If you guys agree I think it's ready for merge.

[ichim-david]

@beyang Actually if I remove the parenthesis now I have to fix the tests so maybe I bring back the parenthesis and the removal I make in another pull request where I get rid of them for good, what do you say?
https://github.com/sourcegraph/cody/actions/runs/13206273654/job/36870044581?pr=6910#step:11:712

[beyang]

sounds good @ichim-david and thanks for the fix here. Anything blocking merging this now?

[ichim-david]

@beyang this is good for merge now, as I’ve mentioned the removal of the logic that added parentheses will need to be done in another pull request along cleaning it from the commands.

[ichim-david]

@ichim-david Sorry for the delay here (we had quite a week with our latest release), I see what you mean with commands wrapping, TL;DR commands are soft deprecated at the moment and will be replaced fully with prompts (we already reached a good enough feature parity with them in prompts library) so I wouldn't worry about commands much here. We can remove wrapping there too.

@vovakulikov I've moved the changes that dropped the parenthesis from the other mentions within this pull request #7022. Since you've mentioned that we could remove the wrapping from them as well I ended up removing the other mention so that the default commands no longer duplicate the context mention behaving like the default prompts that have replaced the command. See more info in the pull request.