Adding cody mcp #6589
Adding cody mcp #6589
Conversation
arafatkatze
force-pushed
the
adding-cody-mcp
branch
2 times, most recently
from
05f7fc9 to
e0bc155
Compare
arafatkatze
force-pushed
the
adding-cody-mcp
branch
from
730d2b8 to
21dfc17
Compare
There was a problem hiding this comment.
I just noticed you are on an old branch so probably unaware of the changes we have on main where we automatically build the tool from openCtx providers via setupOpenCtxProviderListener. In that method we can get the mentions from the MCP and convert them using openCtxProviderMetadata so that we can create the tools for all openCtx providers using the same createOpenCtxTools method.
Let me know if this is confusing or if you have any concerns about this approach!
| public parse(): string[] { | ||
| try { | ||
| JSON.parse(this.unprocessedText) | ||
| } catch { | ||
| return [] | ||
| } | ||
| const unparsedText = this.unprocessedText | ||
| this.reset() | ||
| return [unparsedText] | ||
| } |
There was a problem hiding this comment.
| public parse(): string[] { | |
| try { | |
| JSON.parse(this.unprocessedText) | |
| } catch { | |
| return [] | |
| } | |
| const unparsedText = this.unprocessedText | |
| this.reset() | |
| return [unparsedText] | |
| } |
As discussed, this is for parsing the sub XML tag where the queries are returned by the LLM through stream. we can move this into execute instead
| return [unparsedText] | ||
| } | ||
|
|
||
| public async execute(span: Span, queries: string[]): Promise<ContextItem[]> { |
There was a problem hiding this comment.
it looks like the queries param is not being used here. How does it get the items in this case? 👀
| "openctx.mcp.enable": { | ||
| "type": "boolean", | ||
| "markdownDescription": "Enable OpenCtx providers for Cody.", | ||
| "default": true | ||
| }, | ||
| "openctx.mcp.uri": { | ||
| "type": "string", | ||
| "markdownDescription": "URI for the MCP provider tools in OpenCtx.", | ||
| "default": "" | ||
| }, |
There was a problem hiding this comment.
Q: What's the reason behind having a separated field for these instead of using the existing openctx.providers that handles provider changes?
| @@ -235,6 +237,56 @@ class SearchTool extends CodyTool { | |||
| } | |||
| } | |||
|
|
|||
| export class ModelContextProviderTool extends CodyTool { | |||
There was a problem hiding this comment.
We can use OpenCtxTool to handle this?
arafatkatze
force-pushed
the
adding-cody-mcp
branch
from
21dfc17 to
dbd67b1
Compare
…ovider (#6650) - Asynchronously create OpenCtxTools for model context protocol providers - Implement `createModelContextConfig` to handle the specific configuration for model context protocol providers - ## Test plan <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> Needs to test it with the changes in #6589 --------- Co-authored-by: arafatkatze <[email protected]>
arafatkatze
force-pushed
the
adding-cody-mcp
branch
from
0494a03 to
b408de1
Compare
arafatkatze
force-pushed
the
adding-cody-mcp
branch
from
b408de1 to
0113b3e
Compare
|
|
Related OpenContext PR
Purposely waiting to do the final steps of the PR AFTER the base merge conflicts from Bee's PR is resolved and a demo is shared and discussed properly.
Test plan