Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move BigQuery insertion after release step #6477

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

arafatkatze
Copy link
Collaborator

Problem

The BigQuery insertion step was giving nothing in the version tag because it attempted to access steps.create_release.outputs.version_tag before the release step had run, resulting in missing version data in our bundle size tracking.

image

Solution

Reordered the GitHub Actions workflow steps to ensure the BigQuery insertion happens after the release step, when the version tag is available.

Changes

  • Moved the "Insert data into BigQuery" step to execute after the create_release step
  • No changes to the logic or data structure, just workflow ordering

Test plan

  • Checked github actions

Changelog

@arafatkatze arafatkatze requested a review from abeatrix December 27, 2024 19:23
@arafatkatze arafatkatze enabled auto-merge (squash) December 27, 2024 19:23
@arafatkatze arafatkatze requested a review from a team December 27, 2024 19:24
@arafatkatze arafatkatze merged commit 0c1699a into main Dec 27, 2024
18 of 19 checks passed
@arafatkatze arafatkatze deleted the fixing-bundle-size-tracker branch December 27, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants