fix(middleware): fix promise initialisation (#193)

fix promise initialisation GH-181
sourcefuse · Nov 14, 2024 · b10a585 · b10a585
1 parent be67cb3
commit b10a585
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 22 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/middleware/ratelimit.middleware.ts b/src/middleware/ratelimit.middleware.ts
@@ -54,34 +54,35 @@ export class RatelimitMiddlewareProvider implements Provider<Middleware> {
     }
 
     // Perform rate limiting now
-    const promise = new Promise<void>((resolve, reject) => {
-      // First check if rate limit options available at method level
-      const operationMetadata = metadata ? metadata.options : {};
+    const promise = () =>
+      new Promise<void>((resolve, reject) => {
+        // First check if rate limit options available at method level
+        const operationMetadata = metadata ? metadata.options : {};
 
-      // Create options based on global config and method level config
-      const opts = {...this.config, ...operationMetadata};
+        // Create options based on global config and method level config
+        const opts = {...this.config, ...operationMetadata};
 
-      if (dataStore) {
-        opts.store = dataStore;
-      }
+        if (dataStore) {
+          opts.store = dataStore;
+        }
 
-      opts.message = new HttpErrors.TooManyRequests(
-        opts.message?.toString() ?? 'Method rate limit reached !',
-      );
+        opts.message = new HttpErrors.TooManyRequests(
+          opts.message?.toString() ?? 'Method rate limit reached !',
+        );
 
-      const limiter = RateLimit.default(opts);
-      limiter(request, response, (err: unknown) => {
-        if (err) {
-          reject(err);
-        }
-        resolve();
+        const limiter = RateLimit.default(opts);
+        limiter(request, response, (err: unknown) => {
+          if (err) {
+            reject(err);
+          }
+          resolve();
+        });
       });
-    });
     if (enabledByDefault === true) {
-      await promise;
+      await promise();
       // eslint-disable-next-line  @typescript-eslint/prefer-optional-chain
     } else if (enabledByDefault === false && metadata && metadata.enabled) {
-      await promise;
+      await promise();
     } else {
       return Promise.resolve();
     }