Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sandbox): build sandbox docker-compose file without error #2008

Closed
wants to merge 4 commits into from
Closed

fix(sandbox): build sandbox docker-compose file without error #2008

wants to merge 4 commits into from

Conversation

arpit1503khanna
Copy link
Contributor

Description

Build sandbox docker-compose file without error

Fixes #1969

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@arpit1503khanna arpit1503khanna force-pushed the GH-1969 branch 3 times, most recently from 956a3e5 to afc2484 Compare February 28, 2024 08:57
samarpan-b
samarpan-b requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@samarpan-b samarpan-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are too many changed files. Please run prettier properly to avoid unnecessary changes

@arpit1503khanna arpit1503khanna force-pushed the GH-1969 branch 10 times, most recently from 1c109e0 to acbc707 Compare April 2, 2024 07:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpan-b samarpan-b samarpan-b requested changes

@yeshamavani yeshamavani yeshamavani approved these changes

@akshatdubeysf akshatdubeysf Awaiting requested review from akshatdubeysf akshatdubeysf is a code owner

@Surbhi-sharma1 Surbhi-sharma1 Awaiting requested review from Surbhi-sharma1 Surbhi-sharma1 is a code owner

@Swati0077 Swati0077 Awaiting requested review from Swati0077 Swati0077 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sandbox Docker Compose Does Not Build
3 participants
@arpit1503khanna @samarpan-b @yeshamavani