Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump itertools to 0.13 #466

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

paolobarbolini
Copy link
Contributor

No description provided.

Copy link
Owner

@sourcefrog sourcefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason?

@paolobarbolini
Copy link
Contributor Author

I'm working on packaging this for Alpine Linux and have found that Cargo.lock has not been updated for a while, so some architectures don't compile. Also it's usually good practice to install things using cargo install [package] --locked, so regular users are probably getting old packages too. I've decided to start by bumping crates that have new semver incompatible releases and then send another PR at the end for Cargo.lock.

@sourcefrog
Copy link
Owner

I see. The counterpoint is that newer packages tend to have higher MSRVs which can cause different problems for some people.

I'll be more willing to take these if you can share that e.g. itertools 0.12 doesn't build on riscv or whatever it is.

@paolobarbolini
Copy link
Contributor Author

I see. The counterpoint is that newer packages tend to have higher MSRVs which can cause different problems for some people.

I think it makes sense given especially the recent conversation on rustls bumping MSRV in a security release. I don't see itertools as one of those packages since:

  1. Their current MSRV is 1.43 and their only dependency is either with a MSRV of 1.37 - they both check MSRV on their CIs - they could almost run on the dead Debian 10
  2. They don't seem interested in bumping MSRV Update some of itertools' dev-dependencies to their latest versions rust-itertools/itertools#986 (comment), although an explicit policy does not seem to exist

As for my other two PRs:

nix is supported on Rust 1.69 and higher. Its MSRV will not be changed in the future without bumping the major or minor version.

https://crates.io/crates/nix/0.29.0


I was going to say good things about cargo_metadata, since at least by their incomplete changelog they seemed to bump MSRV just on minor versions, but then I discovered that they bumped MSRV in a patch release two days ago in response of their dependencies also bumping it 🤷‍♂️ 1. There are crates like hyper on the other hand that still support 1.63 even though the latest tokio release does not because the LTS release (one of the few crates that has one) still supports it.

Footnotes

  1. I think it could be talked about with the maintainer https://github.com/oli-obk/cargo_metadata/commit/eae17fb2da575e3e4cc91213718b284cb32d4b2b

@sourcefrog sourcefrog merged commit 924e5d7 into sourcefrog:main Dec 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants