Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explicit control evaluator for agenda and stash visualisation #1430

Merged
merged 13 commits into from
Jun 27, 2023

Conversation

dickongwd
Copy link
Contributor

@dickongwd dickongwd commented Jun 23, 2023

Explicit Control Evaluator Update

Description

This pull request presents incremental updates to the explicit control evaluator for the agenda and stash visualisation on the frontend (link to PR).

Changes

  • Source nodes are added to instructions to support editor highlighting
  • Step counter has been revised to show the Program node at the start of execution
  • Other minor updates to the interpreter's logic

Future Work

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5356077226

  • 48 of 52 (92.31%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 83.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ec-evaluator/interpreter.ts 30 31 96.77%
src/ec-evaluator/utils.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/ec-evaluator/utils.ts 9 81.73%
Totals Coverage Status
Change from base Build 5112940192: -0.1%
Covered Lines: 10617
Relevant Lines: 12308

💛 - Coveralls

@martin-henz martin-henz merged commit 7293bbf into source-academy:master Jun 27, 2023
1 check passed
@martin-henz
Copy link
Member

All changes look good to me. The location information is necessary for the line highlighting feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants