Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler bug fixes #52

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Compiler bug fixes #52

merged 13 commits into from
Oct 8, 2024

Conversation

1001mei
Copy link
Contributor

@1001mei 1001mei commented Apr 13, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
72.79% (+0.06% 🔼)
 7061/9701
🔴 Branches
59.64% (+0.03% 🔼)
 2326/3900
🟡 Functions 67.78% 1256/1853
🟡 Lines
73.68% (+0.07% 🔼)
 6650/9025
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / peggy-functions.ts
 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / code-generator.ts
94.41% (-0.11% 🔻)
84.66% (-1.89% 🔻)
 93.18%
94.75% (-0.13% 🔻)

Test suite run success

1095 tests passing in 57 suites.

Report generated by 🧪jest coverage report action from a5e3fdb

martin-henz
martin-henz requested changes Apr 14, 2024
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function addLocInfo is duplicated. You may be able to avoid the duplication by including it as a dependency in the call of peggy.generate.

AprupKale
AprupKale approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@AprupKale AprupKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

martin-henz
martin-henz approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now

@martin-henz martin-henz merged commit daca8ee into main Oct 8, 2024
5 checks passed
@martin-henz martin-henz deleted the compiler branch October 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@AprupKale AprupKale AprupKale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1001mei @martin-henz @AprupKale