Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode slice for message passing with extension #3080

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

heyzec
Copy link

@heyzec heyzec commented Jan 14, 2025

Description

FYP: Source Academy as Visual Studio Code Extension

This PR makes the frontend's behavior change conditionally when it detects itself to be running as an iframe in the VS Code extension. This is required so that it can send and receive the editor text contents, encapsulated as messages, to the VS Code extension.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code

@heyzec heyzec requested a review from RichDom2185 January 14, 2025 08:56
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this! Could you update the test snapshots?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12947091999

Details

  • 30 of 48 (62.5%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 31.22%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/application/actions/VscodeActions.ts 1 2 50.0%
src/commons/application/reducers/VscodeReducer.ts 5 6 83.33%
src/features/vscode/messages.ts 9 15 60.0%
src/commons/application/Application.tsx 8 18 44.44%
Totals Coverage Status
Change from base Build 12903997600: 0.02%
Covered Lines: 4860
Relevant Lines: 14681

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants