-
Notifications
You must be signed in to change notification settings - Fork 169
Conversation
Fixes for integer overflow issues mentioned in #813 |
@nguyenthanhvuh Did you see the CI results? Please ask if you need help / have questions. |
@dbeyer yep, working on it |
@dbeyer I've made some changes to fix the errors given by the previous CI build. But now the CI build has a timeout problem that I am not sure how to proceed. Could you help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including limits.h
requires to add the preprocessed .i
-files.
Please execute some comand like cpp -m32 -P FILE.c > FILE.i
and add the new .i
-files.
Additionally change the yml-files to reference the .i
-files.
This should only be done for files that use macros, e.g. include
statements.
UPDATE: directly done on my own.
Related topic: Why did the CI-check not detect this?
This avoids the need for a preprocessed version of the file.
and change corresponding benchmark yml files.
The changes replace several @dbeyer you can merge this PR, as soon as the CI passes. |
Thanks a lot! |
@kfriedberger @dbeyer thank you. |
Sorry, I must have missed this PR. One could have added the overflow verdict |
programs added to new and appropriately named directory
license present and acceptable (either in separate file or as comment at beginning of program)
contributed-by present (either in README file or as comment at beginning of program)
programs added to a
.set
file of an existing category, or new sub-category established (if justified)intended property matches the corresponding
.prp
fileprograms and expected answer added to a
.yml
file according to task definitions.cfg
file