Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theta tool-info module update #1091

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

leventeBajczi
Copy link
Contributor

This PR modifies how Theta interprets its output (esp. regarding before- and after-parsing errors).

@PhilippWendler
Copy link
Member

Just as confirmation: Can you clarify that this just changes the wording of ERROR results and does not otherwise change the semantics, i.e., is backwards compatible?

@leventeBajczi
Copy link
Contributor Author

Just as confirmation: Can you clarify that this just changes the wording of ERROR results and does not otherwise change the semantics, i.e., is backwards compatible?

The following changes have been made:

  • Previously, in the case of an error after parsing, we discarded the actual error (this was a bug introduced in ba7d613), because after finding the ParsingResult Success content in a line, we set status to Parsing OK, and therefore, skip the error detection based on exit code. This will affect how the output of Theta is reported (changing Parsing OK results to actual errors), but I consider this a bugfix, rather than a breaking change.
  • We added a new exit code, 209, for unsupported source elements (this won't affect older versions, they simply do not produce this exit code)
  • We clarified in the exit code-based statuses if they happened before or after parsing (this will slightly affect very old versions of Theta (prior to SV-COMP'23), as they don't print ParsingResult Sucess, so every error status will state it is before parsing finished. I don't consider this problematic, as these versions also didn't use the current exit-code based determination of error cause, so most likely, they will remain unspecified errors.)

@PhilippWendler PhilippWendler merged commit 68005e6 into sosy-lab:main Oct 21, 2024
7 checks passed
@leventeBajczi leventeBajczi deleted the theta-update-2024 branch October 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants