Fix bogus warning message "subprocess is still running" #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object Popen in the subprocess module holds the exit code of the process in its internal state, which is only set if the provided methods to wait for process termination are used or poll is called. If the exit code is not set, a bogus warning message occours on destruction of the object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073.
Popenin thesubprocessmodule holds the exit code of the process in its internal state, which is only set if the provided methods to wait for process termination in the Popen class are used orpollis called.If the exit code is not set, a bogus warning message occurs on destruction of the object - to prevent it, we can explicitly call poll after process termination to update the exit code.