Create a tool-info module for BtorMC #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing only `--version` to BtorMC, the tool does not terminate, an EOF (ctrl-D) has to be passed to stdin additionally.
Po-Chun-Chien
commented
May 27, 2024
`btormc --version` requires receiving EOF to terminate. Version: https://github.com/Boolector/boolector/tree/6603ed7b8d401f9bf387f32c702e3e938c50924d See also: Boolector/boolector#225
PhilippWendler
added a commit
that referenced
this pull request
Jun 7, 2024
In the function that most tool-info modules use for getting the version number from the tool, we did not specify what stdin of the tool should be. The unfortunate default for this is the same as stdin of the calling tool, i.e., BenchExec. This means that if a tool would read from stdin while we call it to get its version, it would either hang due to no input or even read from what the user attempted to pass to BenchExec. Both is not good and this happened in #1045. Now we explicitly specify /dev/null as stdin, such that when attempting to read the tool just gets EOF. We also use /dev/null for stdin by default for the actual tool execution since 564f18f (BenchExec 0.5), so I do not expect any problems. Tools who do not read from stdin are not affected, and for tools who do read it is just an improvement that they get EOF instead of waiting for input.
- After 9997760, BtorMC's version extraction does not require special handling
Po-Chun-Chien
pushed a commit
to Po-Chun-Chien/benchexec
that referenced
this pull request
Jun 7, 2024
In the function that most tool-info modules use for getting the version number from the tool, we did not specify what stdin of the tool should be. The unfortunate default for this is the same as stdin of the calling tool, i.e., BenchExec. This means that if a tool would read from stdin while we call it to get its version, it would either hang due to no input or even read from what the user attempted to pass to BenchExec. Both is not good and this happened in sosy-lab#1045. Now we explicitly specify /dev/null as stdin, such that when attempting to read the tool just gets EOF. We also use /dev/null for stdin by default for the actual tool execution since 564f18f (BenchExec 0.5), so I do not expect any problems. Tools who do not read from stdin are not affected, and for tools who do read it is just an improvement that they get EOF instead of waiting for input.
Po-Chun-Chien
added a commit
to Po-Chun-Chien/benchexec
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.