Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug on task filter clearance #1040

Merged
merged 3 commits into from
May 23, 2024
Merged

Fixed bug on task filter clearance #1040

merged 3 commits into from
May 23, 2024

Conversation

JawHawk
Copy link
Member

@JawHawk JawHawk commented May 21, 2024 •
edited by PhilippWendler
Loading

Fixes #1032 .

  • Enables task text when task filter is not applied

PhilippWendler
PhilippWendler reviewed May 21, 2024
View reviewed changes
Copy link
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a plausible fix.

I have just some code-style question.

And could you please also commit the rebuilt JS file?

benchexec/tablegenerator/react-table/src/components/ReactTable.js Outdated Show resolved Hide resolved
@PhilippWendler
Copy link
Member

Thanks! It seems something in your environment creates a different vendors.min.js file than what CI produces. Maybe try running npm ci to install the dependencies before building?

@PhilippWendler
Copy link
Member

For this PR, I have recreated the file and will merge it, no need to do anything.

@PhilippWendler PhilippWendler merged commit 1c2ac5e into sosy-lab:main May 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippWendler PhilippWendler PhilippWendler approved these changes

Assignees
No one assigned
Labels
HTML table
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filters for left-most column remain disabled after clearing Task Filter
2 participants
@JawHawk @PhilippWendler