-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle special characters in filters #1016
Handle special characters in filters #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Does the handling of _
and other special characters also work for filters that are set for other textual columns, i.e., not the id column?
I am also a little bit skeptical about the existing filter-parsing logic. Could you please add tests that have just one an opening parentheses? I would like to see that this works as well.
Yes, even the online example |
Thanks for investigating! Would you like to add this to this PR? |
I have done the necessary changes. Please review them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Seems to work fine in my tests. I also like that many unit tests are added, this is always good.
I have just some minimal suggestions left, but otherwise it is ready to merge from my point of view. If you agree, could you please also update the pre-built files?
d2ccdef
to
265c440
Compare
Fixes #1015
Fixes #806
Solved the Id filter being removed when other filters are applied by fixing the
setURLParameter
function.Added
encodeURIComponent
inmakeFilterSerializer
function to escape special characters anddecodeURIComponent
intokenizePart
function to get the filter value back.Also fixed
decodeFilter
for column names having_