Visted_locations app: Adds radius, notes and date_visited to "visited_locations" models #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezoito
changed the title
pictos
added
awaiting review
|
@dezoito please, update your PR. And we'll work on the review. |
|
Pictos, The changes I had proposed were already implemented by @brunolcarli . Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per suggestion on issue #41, adds the following fields to the visited_locations model:
radius: Optional (default: 1) - Approximated radius visited around coordinates (this information enables circumferences to be drawn on the map providing a better understanding of the area covered
notes: (text field) - Allows users to leave notes and observations on the area visited (e.g.: need to revisit, equipment needed, what was found)
date_visited: self explanatory
@vaniaon @brunolcarli