Add miRBase client #912
Merged
Add miRBase client #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the failing tests are from code that has to do with PubMed client... Unrelated to this PR |
cthoyt
commented
Jul 17, 2019
| yield mirbase_id, mirbase_name, db, identifier, name.rstrip('.') | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| """ |
There was a problem hiding this comment.
Hey, what's going on here?
There was a problem hiding this comment.
D'oh, commented stuff out for testing and then forgot to uncomment 🤦♂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a client for miRBase, which is a nomenclature for micro-RNAs. It adds a function for downloading and structuring the resource as a TSV that has cross-references to ncbigene and other organism specific databases. The client has lookup for terms by miRBase name, identifier, or HGNC. This PR also updates the PyBEL processor to handle nodes named with miRBase.
A few questions about adding this client:
Should I add the resources in a versioned way? The .gitignore seems to reject stuff in the resources folderI added it with 8211c4a because I couldn't pass the tests and it looks like everything else is already addedis_mirna()function like theis_kinase()and related?