Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 창업 중 필터링 추가 #1689

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: 창업 중 필터링 추가 #1689

merged 1 commit into from
Nov 11, 2024

Conversation

seojisoosoo
Copy link
Member

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 커피챗 홈에서 창업 중 필터링을 추가했어요

🤔 그렇다면, 어떻게 구현했어요~?

  • 커피챗 홈 constant 라벨에 창업 중을 추가해주었어요.

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

  • 커피챗 업로드 칩 라벨이랑 홈 필터링 라벨이랑 동일한 constants 사용하도록 리팩토링해볼게요 꼭
  • 그리고 현재 셀렉트박스에 선택한 옵션이 defaultValue로는 들어가는데, 셀렉트박스 펼쳤을 때에는 체크가 안되어있는 것 같아요. 이부분도 수정 같이 진행하면 좋을 것 같습니다.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

스크린샷 2024-11-11 오후 1 10 29

Copy link

height bot commented Nov 11, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@seojisoosoo seojisoosoo self-assigned this Nov 11, 2024
@github-actions github-actions bot requested a review from simeunseo November 11, 2024 04:12
Copy link

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

🚀 프리뷰 배포 확인하기 🚀

https://22273891.sopt-internal-dev.pages.dev

Comment on lines +197 to +198
label: '창업 중',
value: 7,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!!

@seojisoosoo seojisoosoo added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 6d60f4d Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 창업 중 필터링 추가
2 participants