Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Empty View 컴포넌트 분리 #1618

Merged
merged 3 commits into from
Nov 4, 2024
Merged

feat: Empty View 컴포넌트 분리 #1618

merged 3 commits into from
Nov 4, 2024

Conversation

pepperdad
Copy link
Member

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

EmptyView를 컴포넌트로 사용할 수 있도록 분리했습니다.

🤔 그렇다면, 어떻게 구현했어요~?

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

[PC]
Screenshot 2024-10-29 at 4 12 47 PM

[Mobile]
Screenshot 2024-10-29 at 4 12 37 PM

Copy link

github-actions bot commented Oct 29, 2024

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

github-actions bot commented Oct 29, 2024

🚀 프리뷰 배포 확인하기 🚀

https://9953f9e1.sopt-internal-dev.pages.dev

@pepperdad pepperdad self-assigned this Oct 29, 2024
Copy link
Member

@simeunseo simeunseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼭 필요했던 작업인데 너무 감사합니다 👏👏

@pepperdad pepperdad added this pull request to the merge queue Nov 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 2, 2024
Copy link
Member

@seojisoosoo seojisoosoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

…-frontend into feat/#1617

; Conflicts:
;	src/components/members/main/MemberList/index.tsx
@pepperdad pepperdad added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit e505106 Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Empty View 컴포넌트로 분리
3 participants