Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skill이 공백인 경우 예외처리 #1579

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix: skill이 공백인 경우 예외처리 #1579

merged 1 commit into from
Sep 29, 2024

Conversation

seojisoosoo
Copy link
Member

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 프로필 업로드 시, 스킬 input은 필수 입력 항목인데, 이 인풋을 공백으로 입력하는 경우에도 프로필이 등록되는 오류가 있어서 해결했어요.

🤔 그렇다면, 어떻게 구현했어요~?

  • yup 내장기능을 이용, trim() 을 추가해주어서 공백이 있는 경우를 자르는 내용을 추가해주었어요.

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

Copy link

height bot commented Sep 29, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@seojisoosoo seojisoosoo self-assigned this Sep 29, 2024
@github-actions github-actions bot requested a review from pepperdad September 29, 2024 06:54
@seojisoosoo seojisoosoo requested review from simeunseo and removed request for pepperdad September 29, 2024 06:55
Copy link

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

🚀 프리뷰 배포 확인하기 🚀

https://57c277b8.sopt-internal-dev.pages.dev

Copy link
Member

@simeunseo simeunseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@seojisoosoo seojisoosoo added this pull request to the merge queue Sep 29, 2024
Merged via the queue into main with commit bc50f21 Sep 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 프로필 업로드 시, skill이 공백인 경우 예외처리
2 participants