Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 다짐 메시지 모달 칩 스타일 변경 #1574

Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: 다짐 메시지 모달 칩 스타일 변경 #1574

merged 4 commits into from
Sep 27, 2024

Conversation

simeunseo
Copy link
Member

@simeunseo simeunseo commented Sep 27, 2024

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

모달 칩 레이아웃이 피그마와 동일하도록 수정했습니다.

🤔 그렇다면, 어떻게 구현했어요~?

피그마를 다시 확인해보니 모바일과 데스크탑에서 칩의 레이아웃이 상이하더라구요!
따라서 media query로 세부적인 부분 조정해주었습니다.

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

기존에는 이렇게 모바일버전에서 봤을 때 칩 영역 좌우에 패딩이 없고 칩 간의 gap이 피그마와 다른 것이 문제였습니다!

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

PC

image

MO

Copy link

height bot commented Sep 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Sep 27, 2024

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

github-actions bot commented Sep 27, 2024

🚀 프리뷰 배포 확인하기 🚀

https://c98dd5c2.sopt-internal-dev.pages.dev

Copy link
Member

@seojisoosoo seojisoosoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳!!

@simeunseo simeunseo added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit d9ee53f Sep 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 다짐메시지 모달 칩 영역 디자인 수정
2 participants