Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mds 와의 스타일 충돌 해결 #1568

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix: mds 와의 스타일 충돌 해결 #1568

merged 1 commit into from
Sep 28, 2024

Conversation

seojisoosoo
Copy link
Member

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 버튼에 적용되어있던 color 스타일을 지워주었어요.
button,
  [type='button'],
  [type='reset'],
  [type='submit'] {
    appearance: button;

    /* color: ${colors.gray10}; */
  }

🤔 그렇다면, 어떻게 구현했어요~?

  • reset.ts 의 스타일을 삭제 후 발생할 사이드 이펙트가 없는지, button 태그를 사용한 모든 컴포넌트를 훑었어요!

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

  • 거의 다 버튼에 color값을 한 번 더 부여하여서, 큰 사이드 이펙트는 없더라구요..!

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

Copy link

height bot commented Sep 24, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

🚀 프리뷰 배포 확인하기 🚀

https://cad85dfe.sopt-internal-dev.pages.dev

@seojisoosoo seojisoosoo self-assigned this Sep 24, 2024
Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왕 너무 고생하셨습니다 🚀🚀

@seojisoosoo seojisoosoo added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit f49aa37 Sep 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: mds 버튼 적용을 위한 작업
2 participants