[FEAT/#17] 가입 계정 플랫폼 조회 기능 구현 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
- 비로그인 상태에서 조회가 가능한 기능이기 때문에 userId가 아닌 name & phone을 Command로서 받습니다.
- TODO : 추후 "이름 입력" 기능 추가 시, parameter required true로 변경 필요
- `spring.jpa.hibernate.properties.database-platform` - `spring.jpa.hibernate.properties.database`
<TODO> - 현재 Jwt Test 설정 및 리소스 파일 인식 과정에서의 Jwt Encoder Bean 생성 오류로 인해 일시적으로 local profile로 local property 소스를 활용하도록 했습니다. - 추후 오류 해결에 따른 test profile 반영이 필요합니다.
sung-silver
requested changes
Dec 9, 2024
src/main/java/sopt/makers/authentication/application/auth/api/SocialAccountApiController.java
Outdated
Show resolved
Hide resolved
src/main/java/sopt/makers/authentication/application/auth/api/SocialAccountApiController.java
Outdated
Show resolved
Hide resolved
src/main/java/sopt/makers/authentication/support/code/domain/success/AuthSuccess.java
Outdated
Show resolved
Hide resolved
src/main/java/sopt/makers/authentication/support/code/domain/success/UserSuccess.java
Outdated
Show resolved
Hide resolved
...ava/sopt/makers/authentication/usecase/auth/service/GetSocialAccountPlatformServiceTest.java
Outdated
Show resolved
Hide resolved
...ava/sopt/makers/authentication/usecase/auth/service/GetSocialAccountPlatformServiceTest.java
Outdated
Show resolved
Hide resolved
...ava/sopt/makers/authentication/usecase/auth/service/GetSocialAccountPlatformServiceTest.java
Outdated
Show resolved
Hide resolved
- [참고리뷰](#27 (comment))
- 와일드 카드 static import 제거 - Parameterized 전환 - DisplayName 지정
sung-silver
approved these changes
Dec 10, 2024
...ava/sopt/makers/authentication/usecase/auth/service/GetSocialAccountPlatformServiceTest.java
Show resolved
Hide resolved
hyunw9
approved these changes
Dec 10, 2024
src/main/java/sopt/makers/authentication/application/auth/api/AuthApiController.java
Show resolved
Hide resolved
src/main/java/sopt/makers/authentication/support/security/filter/JwtAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🚀
Work Description ✏️
TODO
PR Point 📸
※ Request Spec
본래 보통의 유저 정보 조회의 경우, "유저 식별 정보(User ID)" 기반으로 조회하는 경우가 대다수입니다.
하지만 본 기능의 경우, "비로그인 상황"에서 요청되는 "가입 계정 조회"이기 때문에 유저 식별 정보를 통해 클라이언트와 통신하는 것은 바람직하지 않다고 판단함과 동시에
GET메소드의 API 이기 때문에본 PR과 같이
name&phone을 파라미터로 담아 조회할 수 있도록 구현했습니다.(
nameparameter의 경우, 본래 필수적인 요소이긴 하나 앱 Native View 내 개인정보 수집으로 인한 앱 배포 심사 통과가 어렵다는 점을 감안하여required=false옵션을 추가해 해당 파라미터가 지금으로선 존재하진 않더라도 기능할 수 있도록 구현했습니다.)이러한 방식이 바람직한지 계속해서 고민 중에 있습니다!
위 방식에 이견이나 우려점이 있으시다면 편하게 말씀해주세요!!