mypy: add --disallow-incomplete-defs option

[Exirel]

Description

Tin, with the necessary type definition fix. Related to #2603 for Sopel 8.0.1.

Note: I used Any in several places, in particular in sopel.tools.identifiers. I'm not really happy about it. However, the best fix is to properly type annotate instances, i.e. doing something like users: dict[str, User] = SopelIdentifierMemory() as it should properly type check the users sopel memory object.

Checklist

• I have read CONTRIBUTING.md
• I can and do license this contribution under the EFLv2
• No issues are reported by make qa (runs make lint and make test)
• I have tested the functionality of the things this change touches

[Exirel]

I rebased that over master and it passes the 3.13 mypy check as well!

[dgw]

It's a constant battle to keep the docs clean, with only the type annotations or hints in the :param: declarations, but not both.

While you go through and look for those (I didn't annotate every one, especially since many are outside where GH will allow line notes), also double check that merging #2285 didn't introduce any new wrinkles for this mypy option? 🙏

[Exirel]

but not both.

I fixed the functions I touched, and then fixed some for good measure!

double check that merging #2285 didn't introduce any new wrinkles for this mypy option? 🙏

That would require a rebase first, so you tell me if it's OK and I'll do.

[dgw]

Lots of good stuff in here, but I do have a few questions (the same one in multiple places, actually) about the choice of type annotation syntax. Overall very impressed with how thorough you were with cleaning up the docstrings!

double check that merging #2285 didn't introduce any new wrinkles for this mypy option? 🙏

That would require a rebase first, so you tell me if it's OK and I'll do.

Now that I think about it, your fixups were tested against the latest master, including the merged changes from #2285. It passed, so you can just squash out the fixups after we settle the syntax question.

[dgw]

Cleaned history all good.

I'll have to check other open PRs against this after merging, or make them re-run CI somehow. That's a future-me problem, for later in the week. 😁

[SnoopJ]

Had some remarks, but if the type checker is happy then so am I!