tools.memories: remove obsolete LGTM tricks #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't using LGTM any more, and thus don't need to trick it into suppressing a warning about attributes that were added to `SopelMemory` vs. the base `dict` object it's extending. I don't think this'll do anything in CI, but it fixes a mypy error that seems to only appear on my system. Since there's no technical reason for these assignments to exist, rather than wast time figuring out how to fix the type-check error, let's just remove them.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't using LGTM any more, and thus don't need to trick it (46f184e, part of #1754) into suppressing a warning about attributes that were added to
SopelMemoryvs. the basedictobject it's extending.I don't think this'll do anything in CI, but it fixes a mypy error that seems to only appear on my system. Since there's no technical reason for these assignments to exist, rather than wast time figuring out how to fix the type-check error, let's just remove them.
Like LGTM, the CodeQL static analysis we use now is also difficult/impossible to use effectively on a local machine, so if this brings up any new alerts I/we will have to decide what to do after the fact.
Checklist
make qa(runsmake lintandmake test)make lintlocally was in fact the entire reason I made this PR. 😁Update post-analysis
Yes, now
SopelMemorytriggers thepy/missing-equalsrule due to adding alockattribute without overriding__eq__. IMO removing the existing silly approach is worthwhile without immediately figuring out the best way to resolve the new alert.